Support svg-images in more Editors#1761
Support svg-images in more Editors#1761HannesWell wants to merge 1 commit intoeclipse-pde:masterfrom
Conversation
| FileExtensionsFilter filter = new FileExtensionsFilter(); | ||
| filter.addFileExtension("gif"); //$NON-NLS-1$ | ||
| filter.addFileExtension("png"); //$NON-NLS-1$ | ||
| filter.addFileExtension("svg"); //$NON-NLS-1$ |
There was a problem hiding this comment.
I'm not sure if SVG can be generally allowed for images that are associated with the application window? This might be renderer natively by the OS.
| "attribute", "value"}; //$NON-NLS-1$ //$NON-NLS-2$ | ||
|
|
||
| private static final String[] VALID_IMAGE_TYPES = {"png", "bmp", "ico", "gif", "jpg", "tiff"}; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ //$NON-NLS-5$ //$NON-NLS-6$ | ||
| private static final Set<String> VALID_IMAGE_TYPES = Set.of("svg", "png", "bmp", "ico", "gif", "jpg", "tiff"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$ //$NON-NLS-5$ //$NON-NLS-6$ //$NON-NLS-7$ |
There was a problem hiding this comment.
Actually every image format that SWT supports could be listed here.
Maybe we should consider to introduce some kind of ImageFileDialog as extension of FileDialog that allows to load and save images of the formats that SWT supports and returns the path or even the Image/ImageData directly as convenience.
There was a problem hiding this comment.
AWT allows to enumerate supported images (with Java SPI + ImageReader interface) in what case e.g. JFace could offer such smarter FileChooser Dialogs...
HannesWell
force-pushed
the
support-svg-in-editors
branch
from
5e8cb88 to
b5154e1
Compare
Test Results 285 files 285 suites 51m 53s ⏱️ Results for commit 8eaabb3. ♻️ This comment has been updated with latest results. |
- Support SVG icons as custom Extension-Element icons - Support SVG images as About-dialog image of products - Support SVG images as Windows image of products and use the SVG-format in extension-point schema examples.
HannesWell
force-pushed
the
support-svg-in-editors
branch
from
b5154e1 to
8eaabb3
Compare
2 participants
and use the SVG-format in extension-point schema examples.