Skip to content

Add missing eclipse.svg#1767

Merged
merks merged 1 commit intoeclipse-pde:masterfrom
merks:pr-missing-eclipse-svg
May 7, 2025
Merged

Add missing eclipse.svg#1767
merks merged 1 commit intoeclipse-pde:masterfrom
merks:pr-missing-eclipse-svg

Conversation

Copy link
Copy Markdown
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to add a proper SVG at this place is correct.
The SVG itself seems to contain a different "state" of the Eclipse icon than the original PNG one. In this screenshot, you see the old on the left and the new on the right:
image

I am not sure which of them is "correct"/up-to-date, but except for that the new one looks good to me and is definitely better than not having an icon at all :-)

@merks
Copy link
Copy Markdown
Contributor Author

merks commented May 7, 2025

Linux seems to have stalled. I believe nothing tests this change anyway.

@merks merks merged commit 19a6089 into eclipse-pde:master May 7, 2025
17 of 18 checks passed
@merks merks deleted the pr-missing-eclipse-svg branch May 7, 2025 11:54
@HannesWell
Copy link
Copy Markdown
Member

Thank you Ed for this fix. Highly appreciated.

I am not sure which of them is "correct"/up-to-date, but except for that the new one looks good to me and is definitely better than not having an icon at all :-)

Absolutely.

Linux seems to have stalled. I believe nothing tests this change anyway.

I noticed that as well in the recent past. No clue why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants