Skip to content

Clean Code for apitools/org.eclipse.pde.api.tools.tests #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 1 commit into from
May 15, 2025
Merged

Clean Code for apitools/org.eclipse.pde.api.tools.tests #1781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...se.pde.api.tools.tests/src/org/eclipse/pde/api/tools/comparator/tests/EnumDeltaTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ public void test11() {
assertEquals("Wrong element type", IDelta.ENUM_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Not compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Removed @noreference to a new enum constant
*/
Expand All @@ -325,7 +325,7 @@ public void test12() {
assertEquals("Wrong element type", IDelta.ENUM_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Not compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Decrease access for an enum type
*/
Expand All @@ -349,7 +349,7 @@ public void test13() {
assertEquals("Wrong element type", IDelta.ENUM_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Not compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Added deprecation
*/
Expand All @@ -372,7 +372,7 @@ public void test14() {
assertEquals("Wrong element type", IDelta.ENUM_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Not compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Removed deprecation
*/
Expand Down
18 changes: 9 additions & 9 deletions ...e.pde.api.tools.tests/src/org/eclipse/pde/api/tools/comparator/tests/FieldDeltaTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1731,7 +1731,7 @@ public void test70() {
assertEquals("Wrong element type", IDelta.FIELD_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertFalse("Is compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=230189
*/
Expand Down Expand Up @@ -1761,7 +1761,7 @@ public void test71() {
assertEquals("Wrong element type", IDelta.INTERFACE_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertFalse("Is compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=230189
*/
Expand Down Expand Up @@ -1791,7 +1791,7 @@ public void test72() {
assertEquals("Wrong element type", IDelta.INTERFACE_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertFalse("Is compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=244994
*/
Expand All @@ -1815,7 +1815,7 @@ public void test73() {
assertEquals("Wrong element type", IDelta.FIELD_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertFalse("Is compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=244994
*/
Expand Down Expand Up @@ -1846,7 +1846,7 @@ public void test74() {
assertEquals("Wrong element type", IDelta.FIELD_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Not compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=244994
*/
Expand All @@ -1871,7 +1871,7 @@ public void test75() {
assertEquals("Wrong element type", IDelta.FIELD_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Not compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=277925
*/
Expand All @@ -1894,7 +1894,7 @@ public void test76() {
assertEquals("Wrong element type", IDelta.FIELD_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Not compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* https://bugs.eclipse.org/bugs/show_bug.cgi?id=277925
*/
Expand All @@ -1917,7 +1917,7 @@ public void test77() {
assertEquals("Wrong element type", IDelta.FIELD_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Not compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Check decrease field visibility - public to private
*/
Expand All @@ -1940,7 +1940,7 @@ public void test8() {
assertEquals("Wrong element type", IDelta.FIELD_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertFalse("Is compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Check increase field visibility - protected to public
*/
Expand Down
26 changes: 13 additions & 13 deletions ....pde.api.tools.tests/src/org/eclipse/pde/api/tools/comparator/tests/MethodDeltaTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2707,7 +2707,7 @@ public void test112() {
assertEquals("Wrong element type", IDelta.METHOD_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Is compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Changed Map to Map<String, String>
*/
Expand All @@ -2730,7 +2730,7 @@ public void test113() {
assertEquals("Wrong element type", IDelta.CONSTRUCTOR_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Is compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Add type parameters (constructor)
*/
Expand All @@ -2753,7 +2753,7 @@ public void test114() {
assertEquals("Wrong element type", IDelta.CONSTRUCTOR_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Not compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Add checked exception (constructor)
*/
Expand All @@ -2777,7 +2777,7 @@ public void test115() {
assertEquals("Wrong element type", IDelta.CONSTRUCTOR_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Is compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Add unchecked exception (constructor)
*/
Expand All @@ -2801,7 +2801,7 @@ public void test116() {
assertEquals("Wrong element type", IDelta.CONSTRUCTOR_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Is compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Change last parameter from array to varargs (constructor)
*/
Expand All @@ -2824,7 +2824,7 @@ public void test117() {
assertEquals("Wrong element type", IDelta.CONSTRUCTOR_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Not compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Removed unchecked exception (constructor)
*/
Expand All @@ -2848,7 +2848,7 @@ public void test118() {
assertEquals("Wrong element type", IDelta.CONSTRUCTOR_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Is compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Removed checked exception (constructor)
*/
Expand All @@ -2872,7 +2872,7 @@ public void test119() {
assertEquals("Wrong element type", IDelta.CONSTRUCTOR_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Is compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Increased access (constructor)
*/
Expand All @@ -2896,7 +2896,7 @@ public void test120() {
assertEquals("Wrong element type", IDelta.CONSTRUCTOR_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Is compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Non-final to final for @nooverride method
*/
Expand Down Expand Up @@ -2953,7 +2953,7 @@ public void test122() {
assertEquals("Wrong element type", IDelta.API_COMPONENT_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertFalse("Is compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Added deprecation
*/
Expand All @@ -2976,7 +2976,7 @@ public void test123() {
assertEquals("Wrong element type", IDelta.METHOD_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Not compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Removed deprecation
*/
Expand All @@ -2999,7 +2999,7 @@ public void test124() {
assertEquals("Wrong element type", IDelta.METHOD_ELEMENT_TYPE, child.getElementType()); //$NON-NLS-1$
assertTrue("Not compatible", DeltaProcessor.isCompatible(child)); //$NON-NLS-1$
}

/**
* Added public method into protected member interface inside a class tagged
* as noextend
Expand All @@ -3016,7 +3016,7 @@ public void test125() {
IDelta delta = ApiComparator.compare(beforeApiComponent, afterApiComponent, before, after, VisibilityModifiers.API, null);
assertTrue("Not no delta", delta == ApiComparator.NO_DELTA); //$NON-NLS-1$
}

/**
* Added public method into protected member interface inside a class tagged
* as noextend
Expand Down
Loading