Added support to add sources in the Feature Editor

[nburnwal09]

Added checkbox to add sources: #1613

In feature.xml file:

[eclipse-pde-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

build/org.eclipse.pde.build.tests/META-INF/MANIFEST.MF
build/org.eclipse.pde.build.tests/pom.xml
features/org.eclipse.pde-feature/feature.xml
ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
ui/org.eclipse.pde/META-INF/MANIFEST.MF
ui/org.eclipse.pde/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 27570ca0cb223c92ceb8b1f2cf266610e579bd3e Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Wed, 4 Jun 2025 11:13:56 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/build/org.eclipse.pde.build.tests/META-INF/MANIFEST.MF b/build/org.eclipse.pde.build.tests/META-INF/MANIFEST.MF
index bf32c8e70b..551346175a 100644
--- a/build/org.eclipse.pde.build.tests/META-INF/MANIFEST.MF
+++ b/build/org.eclipse.pde.build.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: Tests Plug-in
 Bundle-SymbolicName: org.eclipse.pde.build.tests;singleton:=true
-Bundle-Version: 1.4.800.qualifier
+Bundle-Version: 1.4.900.qualifier
 Bundle-Activator: org.eclipse.pde.build.tests.Activator
 Export-Package: org.eclipse.pde.build.internal.tests;x-internal:=true,
  org.eclipse.pde.build.internal.tests.ant;x-internal:=true,
diff --git a/build/org.eclipse.pde.build.tests/pom.xml b/build/org.eclipse.pde.build.tests/pom.xml
index 1a0b2457fc..1f723a44b2 100644
--- a/build/org.eclipse.pde.build.tests/pom.xml
+++ b/build/org.eclipse.pde.build.tests/pom.xml
@@ -10,7 +10,7 @@
 		<version>4.37.0-SNAPSHOT</version>
 	</parent>
 	<artifactId>org.eclipse.pde.build.tests</artifactId>
-	<version>1.4.800-SNAPSHOT</version>
+	<version>1.4.900-SNAPSHOT</version>
 	<packaging>eclipse-test-plugin</packaging>
 
 	<properties>
diff --git a/features/org.eclipse.pde-feature/feature.xml b/features/org.eclipse.pde-feature/feature.xml
index 76501e8cab..08214fc1b3 100644
--- a/features/org.eclipse.pde-feature/feature.xml
+++ b/features/org.eclipse.pde-feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.pde"
       label="%featureName"
-      version="3.16.300.qualifier"
+      version="3.16.400.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
diff --git a/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
index 0d96f8a730..61b5e3c6e3 100644
--- a/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.core; singleton:=true
-Bundle-Version: 3.20.200.qualifier
+Bundle-Version: 3.20.300.qualifier
 Bundle-Activator: org.eclipse.pde.internal.core.PDECore
 Bundle-Vendor: %provider-name
 Bundle-Localization: plugin
diff --git a/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
index 645e581c4d..69ac002d3d 100644
--- a/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.ui; singleton:=true
-Bundle-Version: 3.16.100.qualifier
+Bundle-Version: 3.16.200.qualifier
 Bundle-Activator: org.eclipse.pde.internal.ui.PDEPlugin
 Bundle-Vendor: %provider-name
 Bundle-Localization: plugin
diff --git a/ui/org.eclipse.pde/META-INF/MANIFEST.MF b/ui/org.eclipse.pde/META-INF/MANIFEST.MF
index 7009ca5dac..f2ecb28070 100644
--- a/ui/org.eclipse.pde/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde/META-INF/MANIFEST.MF
@@ -2,6 +2,6 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde;singleton:=true
-Bundle-Version: 3.13.3100.qualifier
+Bundle-Version: 3.13.3200.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/ui/org.eclipse.pde/pom.xml b/ui/org.eclipse.pde/pom.xml
index de4f83767b..c8bf2e3a42 100644
--- a/ui/org.eclipse.pde/pom.xml
+++ b/ui/org.eclipse.pde/pom.xml
@@ -18,7 +18,7 @@
     <relativePath>../../</relativePath>
   </parent>
   <artifactId>org.eclipse.pde</artifactId>
-  <version>3.13.3100-SNAPSHOT</version>
+  <version>3.13.3200-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
   
   <properties>
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

[github-actions]

Test Results

   765 files  ±0     765 suites  ±0   58m 6s ⏱️ + 4m 14s
 3 611 tests ±0   3 535 ✅ ±0   76 💤 ±0  0 ❌ ±0 
10 833 runs  ±0  10 602 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit f282251. ± Comparison against base commit 77439fd.

♻️ This comment has been updated with latest results.

[nburnwal09]

I have added 2 public APIs in org.eclipse.pde.core, but the maven build is complaining about the org.eclipse.pde.launching bundle minor version update.

Should the public API's be tagged with since tag here?

[gireeshpunathil]

Should the public API's be tagged with since tag here?

I don't think so (based on my experience) but then I am not sure what APIs qualify for since tags. lets wait to hear from @HannesWell or others.

[gireeshpunathil]

also the changes look good to me.

will this change introduce add-sources tag in feature.xml, even when user selection is false / unchecked? is that ok? (mostly question to @HannesWell )

[HannesWell]

Sorry for the late reply and I didn't had the time for a detailed review (the release kept me busy) but I still have this and your other PRs on the top my list! But I'll try to give you quick feedback on the visual parts

I have added 2 public APIs in org.eclipse.pde.core, but the maven build is complaining about the org.eclipse.pde.launching bundle minor version update.

Should the public API's be tagged with since tag here?

You are referring to org.eclipse.pde.internal.core.ifeature.IFeature, aren't you? As the package name segment internal indicates, this interface is actually internal and not considered API (although it's public), so you don't need to add a since tag.

Let's rebase the branch on master. Maybe you had bad luck with the timing and due to the creation of this PR during the beginning of a new release cycle. The latest build is green.

Added checkbox to add sources: #1613

Would it be possible (without too much effort), to add the checkbox on the right side in the Feature content section? IMHO this would be a more suitable location as that is about the feature content, which the check-box can then influence.

[nburnwal09]

Hi @HannesWell

Would it be possible (without too much effort), to add the checkbox on the right side in the Feature content section? IMHO this would be a more suitable location as that is about the feature content, which the check-box can then influence.

The right side part of the overview page it created statically using html tag(PDEUIMessages.OverviewPage_fContent) here

https://github.com/eclipse-pde/eclipse.pde/blob/52475983a6e4463ae7ef7fdb5764a94c92640a06/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/OverviewPage.java#L179-

And the dynamic part is created by extending PDESection.java class.
So it can not be easily taken to the right side in the Feature content section without changing the structure of the code.

[HannesWell]

Would it be possible (without too much effort), to add the checkbox on the right side in the Feature content section? IMHO this would be a more suitable location as that is about the feature content, which the check-box can then influence.

The right side part of the overview page it created statically using html tag(PDEUIMessages.OverviewPage_fContent) here

...

So it can not be easily taken to the right side in the Feature content section without changing the structure of the code.

Understand, too bad. But thanks for checking that. Then let's keep this part as it is.

I have performed an in depth review and found one critical bug that must be fixed and a few things that should be enhanced. But in general it looks good. Thanks for this already.

[nburnwal09]

@HannesWell
I have addressed all your revieew comments. Kindly verify.

[HannesWell]

I have addressed all your revieew comments. Kindly verify.

Thanks for the quick response, I'll my (hopefully final) review by the end of this week.

[nburnwal09]

@HannesWell
Kindly review this whenever you get sometime

[HannesWell]

Thanks for the update it looked quite good.
I just pushed a small update with a few minor code formatting fixes and removal of unnecessary code.

Furthermore I squashed both of your commits into one. Next time, please just update/amend your commit locally and force-push to your PR's branch instead of adding a new commit with updates. We don't have to record the review progress in the git log :)

With that applied this is ready for submission.
Thanks for this contribution again.

[laeubi]

One would now need to add support to P2 org.eclipse.equinox.p2.publisher.eclipse.FeaturesAction for using that flag to make it useful.