Filter Feature Imports according to their specified filter property#1825
Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom Jun 19, 2025
Merged
Filter Feature Imports according to their specified filter property#1825laeubi merged 1 commit intoeclipse-pde:masterfrom
laeubi merged 1 commit intoeclipse-pde:masterfrom
Conversation
If a feature currently uses a 'filter' on an imported plugin this is not considered by PDE and possibly always included. This then leads to the situation that the product launch validation complains because the filter does not match and when running such a launch OSGi prints an error for this plugin as well. This now checks if the plugin has a filter defined and only add it if it matches. Fix eclipse-pde#1820
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a feature currently uses a 'filter' on an imported plugin this is not considered by PDE and possibly always included. This then leads to the situation that the product launch validation complains because the filter does not match and when running such a launch OSGi prints an error for this plugin as well.
This now checks if the plugin has a filter defined and only add it if it matches.
Fix #1820