Do not consider package private references in calculate uses#1830
Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom Jun 21, 2025
Merged
Do not consider package private references in calculate uses#1830laeubi merged 1 commit intoeclipse-pde:masterfrom
laeubi merged 1 commit intoeclipse-pde:masterfrom
Conversation
Currently only private references are ignored, but in OSGi you can not use a package you export (as in this case either the import or the export is discarded via substitution) making package private types also not accessible except for fragments that share the same classloader anyways. Because of this also package private members has to be ignored when calculating uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only private references are ignored, but in OSGi you can not use a package you export (as in this case either the import or the export is discarded via substitution) making package private types also not accessible except for fragments that share the same classloader anyways.
Because of this also package private members has to be ignored when calculating uses.
FYI @tjwatson