Skip to content

Clean Code for ui/org.eclipse.pde.launching #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 1 commit into from
Jun 23, 2025
Merged

Clean Code for ui/org.eclipse.pde.launching #1833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/org.eclipse.pde.launching/src/org/eclipse/pde/launching/ExtraBundleModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
class ExtraBundleModel extends AbstractPluginModelBase {

private static final long serialVersionUID = 1L;
private Path path;
private final Path path;

public ExtraBundleModel(Path path, Map<String, String> manifest) throws BundleException {
this.path = path;
Expand Down
2 changes: 1 addition & 1 deletion ...eclipse.pde.launching/src/org/eclipse/pde/launching/JUnitLaunchConfigurationDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ protected void collectExecutionArguments(ILaunchConfiguration configuration, Lis
Path tmpPath = Path.of(fWorkspaceLocation, testPlugin.getId() + "-fragment.jar"); //$NON-NLS-1$
Files.createDirectories(tmpPath.getParent());
try (JarOutputStream stream = new JarOutputStream(Files.newOutputStream(tmpPath), calcManifest)) {
//TODO Equinox since a while contains the 'data:' URL handler can we use that instead of a real file on disk?
//TODO Equinox since a while contains the 'data:' URL handler can we use that instead of a real file on disk?
}
tmpPath.toFile().deleteOnExit();
Map<String, String> manifest = ManifestElement.parseBundleManifest(new ByteArrayInputStream(out.toByteArray()), null);
Expand Down
Loading