Fix TargetDefinitionResolutionTests#1839
Merged
akurtakov merged 1 commit intoeclipse-pde:masterfrom Jun 27, 2025
Merged
Conversation
Test is supposed to verify that the corresponding source bundles are there and this should be independent of whether it's coming from source feature or not. Test has been extended to actually check that there are source bundles for every bundle in the feature as it was only checking that there are target bundles for all source bundles but if a source bundle was missing that could have easily be missed. Side effect assertion about non-source bundle in source feature is being dropped as source features are on their way out. Fixes eclipse-pde#1838 .
Contributor
|
Yes I recall this test being a pending problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test is supposed to verify that the corresponding source bundles are there and this should be independent of whether it's coming from source feature or not.
Test has been extended to actually check that there are source bundles for every bundle in the feature as it was only checking that there are target bundles for all source bundles but if a source bundle was missing that could have easily be missed.
Side effect assertion about non-source bundle in source feature is being dropped as source features are on their way out.
Fixes #1838 .