Always expect executable to be available in pde.build.tests#1841
Always expect executable to be available in pde.build.tests#1841HannesWell merged 1 commit intoeclipse-pde:masterfrom
Conversation
HannesWell
force-pushed
the
expect-exe-in-tests
branch
from
7e913bf to
10d9001
Compare
HannesWell
force-pushed
the
expect-exe-in-tests
branch
6 times, most recently
from
b2c8cbd to
098abe0
Compare
HannesWell
left a comment
HannesWell
left a comment
There was a problem hiding this comment.
With eclipse-tycho/tycho#5151 installed, this now passes locally.
I just had to disable one test-case for verification builds.
We just have to await until it is available in the Tycho 5 snapshot.
| // In verification builds this file is currently not created. TODO: Fix this! | ||
| assumeTrue(Files.exists(iniFile.getLocation().toPath())); |
There was a problem hiding this comment.
Somehow this ini file is not created properly in the verification test setup.
This was not noticed before because the failure to find the executable disabled the test entirely.
HannesWell
force-pushed
the
expect-exe-in-tests
branch
6 times, most recently
from
fe58fb3 to
1aae887
Compare
HannesWell
force-pushed
the
expect-exe-in-tests
branch
from
1aae887 to
9cc11a4
Compare
and fix look-up of executable in verification tests. Also apply minor simplifications to org.eclipse.pde.build.tests\pom.xml.
HannesWell
force-pushed
the
expect-exe-in-tests
branch
from
9cc11a4 to
2814f95
Compare
|
Looks like this broke the I-Build tests: Probably the assumption that the last part of the stack search is only used in verification builds was wrong and having both paths searched hopefully fixes it again. |
1 participant
No description provided.