Add getAdditionalEntries to IClasspathContributor#1845
Add getAdditionalEntries to IClasspathContributor#1845laeubi merged 1 commit intoeclipse-pde:masterfrom
Conversation
|
@steffenschmitt1 I also noticed that Also to accept your contribution you need to sign the ECA. |
steffenschmitt1
force-pushed
the
master
branch
4 times, most recently
from
6efeac9 to
de34294
Compare
|
What do I need to do regarding the version? And what about the error related to adding the method to the interface? |
|
This needs to be suppressed here sadly. |
steffenschmitt1
force-pushed
the
master
branch
4 times, most recently
from
07740e2 to
40a25ce
Compare
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
The build seems to fail at comparison of the documentation bundle as baseline and current bundle have the same version but different contents. What I don't understand is that the version of that bundle has been bumped for the current release cycle, so I would expect that baseline and current bundle have different versions. @laeubi do you know anything about that build error?
Failed to execute goal org.eclipse.tycho:tycho-p2-plugin:5.0.0-SNAPSHOT:p2-metadata-default (default-p2-metadata-default) on project org.eclipse.pde.doc.user: baseline and build artifacts have same version but different contents
08:26:01 [ERROR] no-classifier: different
08:26:01 [ERROR] reference/api/allclasses-index.html: different
08:26:01 [ERROR] reference/api/index-files/index-7.html: different
08:26:01 [ERROR] reference/api/index-files/index-9.html: different
08:26:01 [ERROR] reference/api/org/eclipse/pde/core/IClasspathContributor.html: different
08:26:01 [ERROR] reference/api/org/eclipse/pde/core/IClasspathContributor2.html: not present in baseline
08:26:01 [ERROR] reference/api/org/eclipse/pde/core/class-use/IClasspathContributor.html: different
08:26:01 [ERROR] reference/api/org/eclipse/pde/core/class-use/IClasspathContributor2.html: not present in baseline
08:26:01 [ERROR] reference/api/org/eclipse/pde/core/package-summary.html: different
08:26:01 [ERROR] reference/api/org/eclipse/pde/core/package-tree.html: different
08:26:01 [ERROR] reference/api/org/eclipse/pde/core/package-use.html: different
08:26:01 [ERROR] reference/api/overview-tree.html: different
Apart from that, the copyright header for the newly introduced interface would need to be updated.
steffenschmitt1
force-pushed
the
master
branch
2 times, most recently
from
f0e032d to
5721bf9
Compare
By upgrading the version of org.eclipse.pde.doc.user, I was able to resolve the issue. However, some tests are still failing, and I don't believe my changes should have any impact on the executable that is reported as missing in those failures. |
The forcequalifierupdate file must be enhanced when new API is added. |
steffenschmitt1
force-pushed
the
master
branch
3 times, most recently
from
ce8b02e to
aa682b5
Compare
laeubi
left a comment
laeubi
left a comment
There was a problem hiding this comment.
It looks fine for me, anyone else has concerns or should we merge it?
|
@steffenschmitt1 sadly in the meanwhile there is a merge conflict, please rebase on master and resolve the conflict then from my side everything seems fine. |
Test Results33 files - 732 33 suites - 732 22s ⏱️ - 54m 28s Results for commit 6f14ebf. ± Comparison against base commit 4c4ad88. This pull request removes 3585 tests.♻️ This comment has been updated with latest results. |
|
I have documented the testfailure here: |
Adds a new method to allow classpath contributor to append additional classpath entries at the end of the calculation process.
|
@steffenschmitt1 thanks for the enhancement and congratulation for your first PDE contribution 🥇 |
4 participants
Currently, it is only possible to add classpath entries at the beginning of the calculation process. However, in order to properly take AccessRule.IgnoreIfBetter into account from all other entries, it is necessary to add entries at the end of the calculation.
This PR introduces a new method that allows classpath contributors to append additional entries at the end of the calculation process, enabling more accurate handling of access rules.