Skip to content

Allow configure initial values for new JUnit launches with preferences#1852

Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom
laeubi:junit_launch_preferences
Jul 8, 2025
Merged

Allow configure initial values for new JUnit launches with preferences#1852
laeubi merged 1 commit intoeclipse-pde:masterfrom
laeubi:junit_launch_preferences

Conversation

@laeubi
Copy link
Copy Markdown
Contributor

@laeubi laeubi commented Jul 7, 2025

Currently PDE creates a new JUnit launch with quite broad default settings that often lead to large launches and users has to adjust them after the first run to their own needs.

This now adds new preference options to control these values chosen for new launch configurations and defaults to the smallest possible configuration that is only the test-plugin and include all requirements automatically.

grafik

@iloveeclipse
Copy link
Copy Markdown
Member

I believe it would make sense to add this to the extra "Launching" sub-page, similar what is done in JDT.
Current page is already overloaded.

@laeubi
Copy link
Copy Markdown
Contributor Author

laeubi commented Jul 7, 2025

Do mean there should be a new Launching Subpage for PDE? Yes the current layout is not optimal but as the other options are also configured here it seems it would require a complete overhaul here the to be consistent.

@iloveeclipse
Copy link
Copy Markdown
Member

but as the other options are also configured here

With "other options" you mean "Workspace Location" block above? Can also be moved to a subpage.

it seems it would require a complete overhaul here the to be consistent.

Not sure what complete overhaul you mean? Just moving some preferences on a dedicated page shouldn't require a complete overhaul?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 7, 2025

Test Results

   765 files  ±0     765 suites  ±0   52m 44s ⏱️ - 6m 26s
 3 611 tests ±0   3 535 ✅ ±0   76 💤 ±0  0 ❌ ±0 
10 833 runs  ±0  10 602 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit 1444fb2. ± Comparison against base commit 0cfe77d.

♻️ This comment has been updated with latest results.

@laeubi laeubi requested a review from HannesWell July 7, 2025 09:38
@laeubi laeubi force-pushed the junit_launch_preferences branch from 86c45d6 to b6a2bbf Compare July 7, 2025 12:15
@laeubi
Copy link
Copy Markdown
Contributor Author

laeubi commented Jul 7, 2025

With "other options" you mean "Workspace Location" block above? Can also be moved to a subpage.

I now moved everything launch related to an own subpage:

grafik

Not sure what complete overhaul you mean? Just moving some preferences on a dedicated page shouldn't require a complete overhaul?

We have 3 API Tools Sub Pages (what better would be one with tabs) and then one would like to move the API tool settings there. Then we have some target related settings that more belong to the target Page and so on... so if one want to do it "good" it would require some more refactorings...

@laeubi laeubi force-pushed the junit_launch_preferences branch from b6a2bbf to 9b3a131 Compare July 7, 2025 12:26
@laeubi laeubi added the noteworthy Noteworthy feature label Jul 7, 2025
Currently PDE creates a new JUnit launch with quite broad default
settings that often lead to large launches and users has to adjust them
after the first run to their own needs.

This now adds new preference options to control these values chosen for
new launch configurations and defaults to the smallest possible
configuration that is only the test-plugin and include all requirements
automatically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

noteworthy Noteworthy feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants