Include fragments when computing dependencies for Extensible-API bundles#1853
Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom Jul 7, 2025
Merged
Conversation
Currently there is an option to either include all fragments, or only non-test fragments. But there is some kind of special bundles (like SWT) that declare a custom 'Eclipse-ExtensibleAPI' header, these are handled special in the way that PDE attaches their fragments to the classpath of projects requiring these. This behavior is currently not reflected when computing required dependencies leading to ClassNotFoundException when launching them. This now adds another check, that if such special bundle is found its fragments are considered when it is not a test bundle project.
laeubi
force-pushed
the
consider_ext_api_when_comp_dep
branch
from
19f87a5 to
cd068ba
Compare
HannesWell
approved these changes
Jul 8, 2025
Member
|
The change looks reasonable, especially to solve the SWT fragment problem. I found the following uses of the
I hope none of these drags in undesired fragments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is an option to either include all fragments, or only non-test fragments. But there is some kind of special bundles (like SWT) that declare a custom 'Eclipse-ExtensibleAPI' header, these are handled special in the way that PDE attaches their fragments to the classpath of projects requiring these. This behavior is currently not reflected when computing required dependencies leading to ClassNotFoundException when launching them.
This now adds another check, that if such special bundle is found its fragments are considered when it is not a test bundle project.