Add null check when getting fragment host wire provider#1860
Add null check when getting fragment host wire provider#1860HannesWell merged 1 commit intoeclipse-pde:masterfrom
Conversation
|
@HannesWell this change resolves the NPE issue for me but I don't know what impacts this has on what that code was intended to achieve |
merks
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for contributing.
Test Results 765 files 765 suites 48m 22s ⏱️ Results for commit 9f0efd1. ♻️ This comment has been updated with latest results. |
HannesWell
left a comment
There was a problem hiding this comment.
Thank you for your contribution, that's great.
I just wonder about the cause of the NPE and if it could be fixed at its root?
Do you have a 'working' (or more not working) example of the referenced issue and could check why the wiring is absent?
For me the root cause was a fragment in my workspace where the host project didn't build due to dependency errors. Which seems a legitimate reason for the provider wiring to be missing |
Yes, makes sense. Then please remove logging the error and then this change is ready for submission. |
If the host is missing or does not build an NPE occurred (issue eclipse-pde#1819)
Done. Thank you for the quick review |
HannesWell
left a comment
There was a problem hiding this comment.
Looks good, thank you!
Nice contribution, this is very welcome.
If the host is missing or does not build an NPE occurred (issue #1819)