Do not remove reexported required bundles#1861
Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom Jul 9, 2025
Merged
Conversation
Currently required bundles that are reexported are flagged as unused, but this will clearly break consumers. Also reexports should usually only be used to support API compatibility with previous contained packages so they are likely often unused in the bundle itself. This now removes all bundles from the unused dependencies so they do not get lost.
This was referenced Jul 9, 2025
Test Results 752 files ±0 752 suites ±0 42m 49s ⏱️ - 1m 4s For more details on these failures, see this check. Results for commit 239bdff. ± Comparison against base commit af4f33b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently required bundles that are reexported are flagged as unused, but this will clearly break consumers. Also reexports should usually only be used to support API compatibility with previous contained packages so they are likely often unused in the bundle itself.
This now removes all bundles from the unused dependencies so they do not get lost.