Use PdeProjectAnalyzer to compute required packages#1862
Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom Jul 10, 2025
Merged
Use PdeProjectAnalyzer to compute required packages#1862laeubi merged 1 commit intoeclipse-pde:masterfrom
laeubi merged 1 commit intoeclipse-pde:masterfrom
Conversation
Currently the GatherUnusedDependenciesOperation uses JDT reference search to determine if a package is used. This is not only very slow but also unreliable as it does not take into account indirect references e.g. from superclasses or method signatures. This now uses the PdeProjectAnalyzer to compute all required packages once and then check if an import is providing such package.
laeubi
force-pushed
the
use_bnd_to_calculate_used
branch
from
c3f027e to
2d76237
Compare
This was referenced Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the GatherUnusedDependenciesOperation uses JDT reference search to determine if a package is used. This is not only very slow but also unreliable as it does not take into account indirect references e.g. from superclasses or method signatures.
This now uses the PdeProjectAnalyzer to compute all required packages once and then check if an import is providing such package.