Skip to content

Add implicit dependencies from the target#1869

Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom
laeubi:add_implicit_deps_to_container
Jul 15, 2025
Merged

Add implicit dependencies from the target#1869
laeubi merged 1 commit intoeclipse-pde:masterfrom
laeubi:add_implicit_deps_to_container

Conversation

@laeubi
Copy link
Copy Markdown
Contributor

@laeubi laeubi commented Jul 14, 2025

Currently if one defines implicit dependencies in the target these only getting added to the launch but not the project, this makes these quite hard to use. The best would be to make this feature more flexible to let the user choose if it is a runtime requirement or a compile dependency.

Unless we have this, it seems the best way is to add it in both cases as indicated in the help:

The Implicit Dependencies section is used to manage the implicit
dependencies of the target. Any plug-in marked as an implicit
dependency will always be added as a required plug-in when PDE
determines requirements.

Currently if one defines implicit dependencies in the target these only
getting added to the launch but not the project, this makes these quite
hard to use. The best would be to make this feature more flexible to let
the user choose if it is a runtime requirement or a compile dependency.

Unless we have this, it seems the best way is to add it in both cases as
indicated in the help:

> The Implicit Dependencies section is used to manage the implicit
> dependencies of the target. Any plug-in marked as an implicit
> dependency will always be added as a required plug-in when PDE
> determines requirements.
@github-actions
Copy link
Copy Markdown

Test Results

  510 files   -   255    510 suites   - 255   28m 51s ⏱️ - 20m 7s
3 611 tests ±    0  3 557 ✅ ±    0   54 💤 ± 0  0 ❌ ±0 
7 223 runs   - 3 611  7 114 ✅  - 3 557  109 💤  - 54  0 ❌ ±0 

Results for commit 804f8e5. ± Comparison against base commit 5c59d79.

@laeubi laeubi merged commit aa6f1da into eclipse-pde:master Jul 15, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant