Skip to content

Fix potential npe in model spy during shutdown#1877

Merged
vogella merged 2 commits intoeclipse-pde:masterfrom
vogella:fix-potential-npe-in-model-spy-during-shutdown
Jul 17, 2025
Merged

Fix potential npe in model spy during shutdown#1877
vogella merged 2 commits intoeclipse-pde:masterfrom
vogella:fix-potential-npe-in-model-spy-during-shutdown

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented Jul 17, 2025

No description provided.

In a client implementation I see the NPE from below. This adds a null
check for this.

java.lang.NullPointerException: Cannot invoke
"org.eclipse.swt.widgets.Button.isDisposed()" because
"this.createRemoveMainMenu" is null
	at org.eclipse.e4.tools.emf.ui.internal.common.component.WindowEditor.lambda$0(WindowEditor.java:369)
@vogella vogella force-pushed the fix-potential-npe-in-model-spy-during-shutdown branch from 16669df to 2c37e6c Compare July 17, 2025 13:33
@eclipse-pde-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF
e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml
features/org.eclipse.e4.core.tools.feature/feature.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 7669b4af4be32b6e1f21afee56acb711f2d41e63 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Thu, 17 Jul 2025 13:40:27 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF
index 0bf31b355b..f21ee0bb80 100644
--- a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF
+++ b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.e4.tools.emf.ui;singleton:=true
-Bundle-Version: 4.8.700.qualifier
+Bundle-Version: 4.8.800.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Bundle-RequiredExecutionEnvironment: JavaSE-17
diff --git a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml
index c0c50de122..760324c2bc 100644
--- a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml
+++ b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml
@@ -21,7 +21,7 @@
 
   <groupId>org.eclipse.platform</groupId>
   <artifactId>org.eclipse.e4.tools.emf.ui</artifactId>
-  <version>4.8.700-SNAPSHOT</version>
+  <version>4.8.800-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
 
   <properties>
diff --git a/features/org.eclipse.e4.core.tools.feature/feature.xml b/features/org.eclipse.e4.core.tools.feature/feature.xml
index 0c8735ca5b..b83fd4b9e0 100644
--- a/features/org.eclipse.e4.core.tools.feature/feature.xml
+++ b/features/org.eclipse.e4.core.tools.feature/feature.xml
@@ -2,7 +2,7 @@
 <feature
       id="org.eclipse.e4.core.tools.feature"
       label="%featureName"
-      version="4.30.500.qualifier"
+      version="4.30.600.qualifier"
       provider-name="%providerName"
       license-feature="org.eclipse.license"
       license-feature-version="0.0.0">
-- 
2.50.1

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown

Test Results

   765 files  ±0     765 suites  ±0   56m 16s ⏱️ +38s
 3 611 tests ±0   3 557 ✅ ±0   54 💤 ±0  0 ❌ ±0 
10 834 runs  ±0  10 671 ✅ ±0  163 💤 ±0  0 ❌ ±0 

Results for commit 4ea33fd. ± Comparison against base commit 4d59605.

@vogella vogella merged commit 630d0d7 into eclipse-pde:master Jul 17, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants