Fix potential npe in model spy during shutdown#1877
Merged
vogella merged 2 commits intoeclipse-pde:masterfrom Jul 17, 2025
Merged
Fix potential npe in model spy during shutdown#1877vogella merged 2 commits intoeclipse-pde:masterfrom
vogella merged 2 commits intoeclipse-pde:masterfrom
Conversation
In a client implementation I see the NPE from below. This adds a null check for this. java.lang.NullPointerException: Cannot invoke "org.eclipse.swt.widgets.Button.isDisposed()" because "this.createRemoveMainMenu" is null at org.eclipse.e4.tools.emf.ui.internal.common.component.WindowEditor.lambda$0(WindowEditor.java:369)
16669df to
2c37e6c
Compare
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.