Add a final check for references of unused packages#1882
Add a final check for references of unused packages#1882laeubi merged 1 commit intoeclipse-pde:masterfrom
Conversation
Currently there is one category of usages that are now no longer detected since we use bndlib to find referenced packages that is if something is only needed at compiletime because the compiler otherwise inline the value. This now restores the previous java search but only for these packages that are selected to be removed. This is faster as we do not need to query all packages and discovers cases where an import is only needed for a compile time constant.
Also when looking at #1862, I was wondering if search provided by JDT should be enhanced somehow in order to be faster in general? |
|
One problem is that currently we also gather all searches where we would be happy with one match... in any case performance is not that important than correctness, so if it work reliable I'm all happy with that at a first step. Also it might be good to cache the searchscope and such kind of optimization. |
Yes absolutely, correctness is the number one priority but speed is also good to have. But before this functionality lacked both.
Yes I was thinking about something like this as well. |
|
Yes, great work! |
3 participants
Currently there is one category of usages that are now no longer detected since we use bndlib to find referenced packages that is if something is only needed at compiletime because the compiler otherwise inline the value.
This now restores the previous java search but only for these packages that are selected to be removed. This is faster as we do not need to query all packages and discovers cases where an import is only needed for a compile time constant.