Skip to content

Update the project with an empty classpath container on initialize #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laeubi merged 1 commit into from
Jul 23, 2025
Merged

Update the project with an empty classpath container on initialize #1887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion ui/org.eclipse.pde.core/src/org/eclipse/pde/internal/core/RequiredPluginsInitializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.eclipse.core.runtime.jobs.Job;
import org.eclipse.jdt.core.ClasspathContainerInitializer;
import org.eclipse.jdt.core.IClasspathContainer;
import org.eclipse.jdt.core.IClasspathEntry;
import org.eclipse.jdt.core.IJavaProject;
import org.eclipse.jdt.core.JavaCore;
import org.eclipse.jdt.core.JavaModelException;
Expand All @@ -43,6 +44,30 @@ public class RequiredPluginsInitializer extends ClasspathContainerInitializer {

private static final DeferredClasspathContainerInitializerJob deferredClasspathContainerInitializerJob = new DeferredClasspathContainerInitializerJob();

private static final IClasspathContainer EMPTY_CLASSPATH_CONTAINER = new IClasspathContainer() {

@Override
public IPath getPath() {
return PDECore.REQUIRED_PLUGINS_CONTAINER_PATH;
}

@Override
public int getKind() {
return K_APPLICATION;
}

@Override
public String getDescription() {
return PDECoreMessages.RequiredPluginsClasspathContainer_description;
}

@Override
public IClasspathEntry[] getClasspathEntries() {
// nothing yet, will be updated soon
return new IClasspathEntry[0];
}
};

private static class DeferredClasspathContainerInitializerJob extends Job {

private final Set<IJavaProject> projects = new LinkedHashSet<>();
Expand Down Expand Up @@ -86,10 +111,20 @@ public boolean belongsTo(Object family) {
@Override
public void initialize(IPath containerPath, IJavaProject javaProject) throws CoreException {
if (Job.getJobManager().isSuspended()) {
// if the jobmanager is currently suspended we can't use the
// If the jobmanager is currently suspended we can't use the
// schedule/join pattern here, instead we must retry the requested
// action once jobs are enabled again, this will the possibly
// trigger a rebuild if required or notify other listeners.
//
// Second as JDT is caching the container state, it might happens
// that the final results are the same and if PDE is too fast, it
// then happens that there is no delta event send to the model
// listeners leading to odd results.
// We explicitly set an empty classpath container here, so JDT will
// always see a delta when we later update the container to its
// final entries.
JavaCore.setClasspathContainer(PDECore.REQUIRED_PLUGINS_CONTAINER_PATH, new IJavaProject[] { javaProject },
new IClasspathContainer[] { EMPTY_CLASSPATH_CONTAINER }, null);
deferredClasspathContainerInitializerJob.initialize(javaProject);
} else {
setupClasspath(javaProject);
Expand Down
Loading