Save and restore the current plugin classpath container state from disk#1898
Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom Jul 26, 2025
Merged
Save and restore the current plugin classpath container state from disk#1898laeubi merged 1 commit intoeclipse-pde:masterfrom
laeubi merged 1 commit intoeclipse-pde:masterfrom
Conversation
Test Results 618 files - 147 618 suites - 147 45m 0s ⏱️ - 5m 13s For more details on these failures, see this check. Results for commit 8a71945. ± Comparison against base commit 847f31d. ♻️ This comment has been updated with latest results. |
Contributor
Author
|
Now this seems to make problems in API Tools test more prominent as things a probably to fast or at least have a different timing: |
merks
requested changes
Jul 26, 2025
Contributor
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
Some minor cosmetic changes.
It appears PDE uses tracing for other things:
laeubi
force-pushed
the
use_saved_state
branch
3 times, most recently
from
01ee2b8 to
ca0216b
Compare
Contributor
Author
|
@merks I now used the debug facility for that |
Computing the bundle plugin classpath can be an expensive operation for different reasons. In many cases these computation even yields the same results as before especially on workspace restart without target changes. This now stores the last successful computed state per project and read it back on initialization of the classpath container, scheduling a check for actual changes in the background. Only if this check yields a different result or the update is requested as part of a change to the manifest or target state for example the current values are updated. This yields faster startup times without the risk of blocking (other than file I/O) until PDE can deliver the classpath to consumers delaying the heavy work to a later time.
merks
approved these changes
Jul 26, 2025
Contributor
Author
|
As it might has an impact due to different timings now I started an I-Build to see if anything goes wrong in the large scale: |
iloveeclipse
added a commit
to iloveeclipse/eclipse.jdt.ui
that referenced
this pull request
Jul 30, 2025
reconcile" This reverts commit 1f01b41. The code in PDE that used ClasspathContainerInitializer.class family is gone, so this code is meaningless now and only increases code complexity. See eclipse-pde/eclipse.pde#1898
iloveeclipse
added a commit
to eclipse-jdt/eclipse.jdt.ui
that referenced
this pull request
Jul 30, 2025
reconcile" This reverts commit 1f01b41. The code in PDE that used ClasspathContainerInitializer.class family is gone, so this code is meaningless now and only increases code complexity. See eclipse-pde/eclipse.pde#1898
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Computing the bundle plugin classpath can be an expensive operation for different reasons. In many cases these computation even yields the same results as before especially on workspace restart without target changes.
This now stores the last successful computed state per project and read it back on initialization of the classpath container, scheduling a check for actual changes in the background. Only if this check yields a different result or the update is requested as part of a change to the manifest or target state for example the current values are updated.
This yields faster startup times without the risk of blocking (other than file I/O) until PDE can deliver the classpath to consumers delaying the heavy work to a later time.