Do not implement IClasspathContainer#1907
Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom Jul 29, 2025
Merged
Conversation
Currently RequiredPluginsClasspathContainer itself implements IClasspathContainer but we actually only need that instance to compute the entries. As the RequiredPluginsClasspathContainer retains some objects in its instance and to make handling more uniform (e.g. regarding equals and hashcode of container instances) this now removes the actual implementation of the interface and simply wraps the resulting entries in a SerializableClasspathContainer that only holds a reference to the entries produced itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
RequiredPluginsClasspathContaineritself implementsIClasspathContainerbut we actually only need that instance to compute the entries.As the
RequiredPluginsClasspathContainerretains some objects in its instance and to make handling more uniform (e.g. regarding equals and hashcode of container instances) this now removes the actual implementation of the interface and simply wraps the resulting entries in aSerializableClasspathContainerthat only holds a reference to the entries produced itself.