Search required bundles for references in sources#1913
Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom Aug 3, 2025
Merged
Search required bundles for references in sources#1913laeubi merged 1 commit intoeclipse-pde:masterfrom
laeubi merged 1 commit intoeclipse-pde:masterfrom
Conversation
Similar to package-imports we need to search for referenced packages from source-only types in case of require bundle. This also improves how searching is done in general by only create some objects once and have a more uniform handling through the Requestor class to avoid code duplication.
Test Results 618 files + 579 618 suites +579 50m 33s ⏱️ + 50m 16s For more details on these failures, see this check. Results for commit 5761602. ± Comparison against base commit 2aea21c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to package-imports we need to search for referenced packages from source-only types in case of require bundle.
This also improves how searching is done in general by only create some objects once and have a more uniform handling through the Requestor class to avoid code duplication.
This should fix some issue we see in Equinox cleanups for example: