Skip to content

TestPDETemplates.createProjectWithTemplate use only supported EE#1932

Merged
merks merged 2 commits intoeclipse-pde:masterfrom
merks:pr-java-25
Aug 17, 2025
Merged

TestPDETemplates.createProjectWithTemplate use only supported EE#1932
merks merged 2 commits intoeclipse-pde:masterfrom
merks:pr-java-25

Conversation

@merks
Copy link
Copy Markdown
Contributor

@merks merks commented Aug 17, 2025

  • The tests fail when running on Java 25 because that's not currently a supported execution environment.

- The tests fail when running on Java 25 because that's not currently a
supported execution environment.
@merks
Copy link
Copy Markdown
Contributor Author

merks commented Aug 17, 2025

@akurtakov

I'm not sure this is the best way to ensure that the tests are configured only with a supported execution environment. The unit tests pass if they avoid configuring JavaSE-25 when running on Java 25 but rather configure it to use Java 24 in that case.

@eclipse-pde-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.ui.templates.tests/META-INF/MANIFEST.MF
ui/org.eclipse.pde.ui.templates.tests/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 61dec44247ee6f6cb33c4e9e96e7fed21196ee6c Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Sun, 17 Aug 2025 06:08:42 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/ui/org.eclipse.pde.ui.templates.tests/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.ui.templates.tests/META-INF/MANIFEST.MF
index bf6fcad191..ad5105b4d9 100644
--- a/ui/org.eclipse.pde.ui.templates.tests/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.ui.templates.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: Tests for PDE templates
 Bundle-SymbolicName: org.eclipse.pde.ui.templates.tests
-Bundle-Version: 1.3.0.qualifier
+Bundle-Version: 1.3.100.qualifier
 Bundle-Vendor: Eclipse.org
 Bundle-ClassPath: tests.jar
 Bundle-RequiredExecutionEnvironment: JavaSE-21
diff --git a/ui/org.eclipse.pde.ui.templates.tests/pom.xml b/ui/org.eclipse.pde.ui.templates.tests/pom.xml
index 749614a458..d4001ac83f 100644
--- a/ui/org.eclipse.pde.ui.templates.tests/pom.xml
+++ b/ui/org.eclipse.pde.ui.templates.tests/pom.xml
@@ -18,7 +18,7 @@
     <relativePath>../../</relativePath>
   </parent>
   <artifactId>org.eclipse.pde.ui.templates.tests</artifactId>
-  <version>1.3.0-SNAPSHOT</version>
+  <version>1.3.100-SNAPSHOT</version>
   <packaging>eclipse-test-plugin</packaging>
 
   <properties>
-- 
2.50.1

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 17, 2025

Test Results

   765 files  +  147     765 suites  +147   50m 13s ⏱️ -41s
 3 611 tests ±    0   3 557 ✅ +    1   54 💤 ± 0  0 ❌  - 1 
10 833 runs  +2 650  10 670 ✅ +2 627  163 💤 +24  0 ❌  - 1 

Results for commit 4d0ab54. ± Comparison against base commit 09b7f61.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the best way to ensure that the tests are configured only with a supported execution environment. The unit tests pass if they avoid configuring JavaSE-25 when running on Java 25 but rather configure it to use Java 24 in that case.

I don't have a better idea than this or just accepting the tests to fail on not yet supported target versions.

@merks merks merged commit d9ad053 into eclipse-pde:master Aug 17, 2025
23 of 24 checks passed
@merks merks deleted the pr-java-25 branch August 17, 2025 17:33
@akurtakov
Copy link
Copy Markdown
Member

Thanks for this one! I have tested with PDE and when run with Java 25 it requries BREE 25 but somehow lower compiler level is used so end users will not face the problem.

@akurtakov
Copy link
Copy Markdown
Member

This brings the failure to https://download.eclipse.org/eclipse/downloads/drops4/I20250820-1800/testresults/html/org.eclipse.pde.ui.templates.tests_ep437I-unit-linux-x86_64-java25_linux.gtk.x86_64_25.html :

Marker [on: /TestPDETemplates_org.eclipse.pde.ui.pluginContent.choice, id: 16, type: org.eclipse.jdt.launching.jreContainerMarker, severity: WARNING(1), attributes: [location: Build path, message: Build path specifies execution environment JavaSE-24. There are no JREs installed in the workspace that are strictly compatible with this environment.], created: 8/20/25, 11:40 PM] expected:<0> but was:<1> 

@laeubi
Copy link
Copy Markdown
Contributor

laeubi commented Aug 21, 2025

@akurtakov the initial issue was likely a result of

what can lead to unexpected results when searching for compatible JVMs based on an EE, beside that the warning is correct at least, so one would maybe want to change the assert to either check for one warning about not matching JRE or no warnings at all as both acceptable.

@akurtakov
Copy link
Copy Markdown
Member

Thanks for the pointers! If/when I have time I'll try to make Java 25 be recognized as Java 24 for consistency reasons. If/what/how is changed via your work should be "extra" fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants