TestPDETemplates.createProjectWithTemplate use only supported EE#1932
TestPDETemplates.createProjectWithTemplate use only supported EE#1932merks merged 2 commits intoeclipse-pde:masterfrom
Conversation
merks
commented
Aug 17, 2025
- The tests fail when running on Java 25 because that's not currently a supported execution environment.
- The tests fail when running on Java 25 because that's not currently a supported execution environment.
|
I'm not sure this is the best way to ensure that the tests are configured only with a supported execution environment. The unit tests pass if they avoid configuring JavaSE-25 when running on Java 25 but rather configure it to use Java 24 in that case. |
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
There was a problem hiding this comment.
I'm not sure this is the best way to ensure that the tests are configured only with a supported execution environment. The unit tests pass if they avoid configuring JavaSE-25 when running on Java 25 but rather configure it to use Java 24 in that case.
I don't have a better idea than this or just accepting the tests to fail on not yet supported target versions.
|
Thanks for this one! I have tested with PDE and when run with Java 25 it requries BREE 25 but somehow lower compiler level is used so end users will not face the problem. |
|
This brings the failure to https://download.eclipse.org/eclipse/downloads/drops4/I20250820-1800/testresults/html/org.eclipse.pde.ui.templates.tests_ep437I-unit-linux-x86_64-java25_linux.gtk.x86_64_25.html : |
|
@akurtakov the initial issue was likely a result of
what can lead to unexpected results when searching for compatible JVMs based on an EE, beside that the warning is correct at least, so one would maybe want to change the assert to either check for one warning about not matching JRE or no warnings at all as both acceptable. |
|
Thanks for the pointers! If/when I have time I'll try to make Java 25 be recognized as Java 24 for consistency reasons. If/what/how is changed via your work should be "extra" fix. |