Fix split package between swt.spies and swt.tools#1943
Merged
akurtakov merged 1 commit intoeclipse-pde:masterfrom Aug 22, 2025
Merged
Fix split package between swt.spies and swt.tools#1943akurtakov merged 1 commit intoeclipse-pde:masterfrom
akurtakov merged 1 commit intoeclipse-pde:masterfrom
Conversation
merks
approved these changes
Aug 22, 2025
Contributor
There was a problem hiding this comment.
+1
This change is related to
eclipse-platform/eclipse.platform.releng.aggregator#3190
because it address this problem in a permanent by avoiding the split package altogether.
laeubi
reviewed
Aug 22, 2025
Move Sleak class to o.e.swt.internal.tools.views. It's more correct (or at least less wrong as per https://github.com/eclipse-platform/eclipse.platform/blob/master/docs/Naming_Conventions.md ). Removes the nasty problem of split packages signed with different certificates.
Member
Author
|
There is PMC member +1 thus merging in order to get the bundle signed proper for RC2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Sleak class to o.e.swt.internal.tools.views. It's more correct (or at least less wrong as per
https://github.com/eclipse-platform/eclipse.platform/blob/master/docs/Naming_Conventions.md ).
Removes the nasty problem of split packages signed with different certificates.