Skip to content

Clean Code for ui/org.eclipse.pde.runtime#2235

Merged
laeubi merged 2 commits intomasterfrom
clean-code/ui/org.eclipse.pde.runtime
Mar 5, 2026
Merged

Clean Code for ui/org.eclipse.pde.runtime#2235
laeubi merged 2 commits intomasterfrom
clean-code/ui/org.eclipse.pde.runtime

Conversation

@eclipse-pde-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@eclipse-pde-bot
Copy link
Copy Markdown
Contributor Author

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.runtime/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 2f4d145b0a29a2415a63b138c950c961679588df Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Mon, 2 Mar 2026 04:11:56 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/ui/org.eclipse.pde.runtime/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.runtime/META-INF/MANIFEST.MF
index 18bd4437a6..9e238ff275 100644
--- a/ui/org.eclipse.pde.runtime/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.runtime/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.runtime; singleton:=true
-Bundle-Version: 3.9.0.qualifier
+Bundle-Version: 3.9.100.qualifier
 Bundle-Activator: org.eclipse.pde.internal.runtime.PDERuntimePlugin
 Bundle-Vendor: %provider-name
 Bundle-Localization: plugin
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 2, 2026

Test Results

   519 files  ±0     519 suites  ±0   1h 3m 4s ⏱️ -54s
 3 602 tests ±0   3 548 ✅ ±0   54 💤 ±0  0 ❌ ±0 
11 127 runs  ±0  10 964 ✅ ±0  163 💤 ±0  0 ❌ ±0 

Results for commit cb88814. ± Comparison against base commit 753c00b.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the clean-code/ui/org.eclipse.pde.runtime branch from 040288f to cb88814 Compare March 5, 2026 04:10
@laeubi laeubi merged commit 38e5986 into master Mar 5, 2026
19 checks passed
@laeubi laeubi deleted the clean-code/ui/org.eclipse.pde.runtime branch March 5, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants