Skip to content

Add reproducer for cyclic bundle dependencies caused by #2218#2254

Closed
ptziegler wants to merge 1 commit intoeclipse-pde:masterfrom
ptziegler:cyclic-dependencies
Closed

Add reproducer for cyclic bundle dependencies caused by #2218#2254
ptziegler wants to merge 1 commit intoeclipse-pde:masterfrom
ptziegler:cyclic-dependencies

Conversation

@ptziegler
Copy link
Copy Markdown
Contributor

No description provided.

@laeubi
Copy link
Copy Markdown
Contributor

laeubi commented Mar 12, 2026

@ptziegler many thanks - I'll take a look into it.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 12, 2026

Test Results

  357 files   -   444    357 suites   - 444   42m 30s ⏱️ - 12m 48s
1 134 tests  - 2 664  1 102 ✅  - 2 642  30 💤  - 24  1 ❌ +1  1 🔥 +1 
3 168 runs   - 7 992  3 073 ✅  - 7 924  91 💤  - 72  3 ❌ +3  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit a8384dd. ± Comparison against base commit 368feba.

This pull request removes 2665 and adds 1 tests. Note that renamed tests count towards both.
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest ‑ executeMethod[JUnit4 (JUnitPlatform) Fragment]
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest ‑ executeMethod[JUnit4 (JUnitPlatform)]
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest ‑ executeMethod[JUnit4 Fragment]
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest ‑ executeMethod[JUnit4]
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest ‑ executeMethod[JUnit5 Fragment]
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest ‑ executeMethod[JUnit5]
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest ‑ executeMethod[JUnit6 Fragment]
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest ‑ executeMethod[JUnit6]
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest ‑ executeMethod[Java 11 bundle with module limit]
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest ‑ executeMethod[Using a 'test' source folder]
…
AllPDETests ClasspathResolutionTest ‑ testRequiredPluginsViaCapabilityForFragment

♻️ This comment has been updated with latest results.

@ptziegler ptziegler force-pushed the cyclic-dependencies branch from 6be28fc to ccedb10 Compare March 12, 2026 11:15
@ptziegler
Copy link
Copy Markdown
Contributor Author

I've also cleaned up the test a little bit to make better use of the ProjectUtils class, so that I don't have to edit the Manifest file directly.

@laeubi
Copy link
Copy Markdown
Contributor

laeubi commented Mar 12, 2026

@ptziegler I included your testcase and a fix here:

@ptziegler
Copy link
Copy Markdown
Contributor Author

@ptziegler I included your testcase and a fix here:

Awesome, thanks! 😄 Then this PR can be closed.

@ptziegler ptziegler closed this Mar 12, 2026
@merks
Copy link
Copy Markdown
Contributor

merks commented Mar 12, 2026

Thank you for immediately taking helpful concrete steps toward a solution!! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants