Fix error with search in XMI-tab of E4WorkbenchModelEditor#2293
Merged
vogella merged 2 commits intoeclipse-pde:masterfrom Apr 19, 2026
Merged
Fix error with search in XMI-tab of E4WorkbenchModelEditor#2293vogella merged 2 commits intoeclipse-pde:masterfrom
vogella merged 2 commits intoeclipse-pde:masterfrom
Conversation
Consider updated text field after key press when searching in the xmi tab instead of the out-dated one
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
|
LGTM, thanks |
Contributor
|
Follow-up PR with tests would be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is an issue with the search functionality inside of the XMI tab of the E4WorkbenchModelEditor: When searching for a specific text, the search "lags" behind the last entered character and thus only highlights the previously entered text.
This is caused by the search highlighting being recalculated on a keyPressed-Event. This event happens before the text value of the search field is recalculated. In order to fix this issue, the search highlighting should instead react to modification events of the underlying text field (in cases in which the entered character causes the text field to update).
How to reproduce/test:
I've tried adding some tests for this PR, but I could not find any test plugin for org.eclipse.e4.tools.emf.ui.
Should I create a follow-up PR adding a new test plugin with some tests for this PR?