Skip to content

Fix error with search in XMI-tab of E4WorkbenchModelEditor#2293

Merged
vogella merged 2 commits intoeclipse-pde:masterfrom
r-mennig:fixed_search_xmitab
Apr 19, 2026
Merged

Fix error with search in XMI-tab of E4WorkbenchModelEditor#2293
vogella merged 2 commits intoeclipse-pde:masterfrom
r-mennig:fixed_search_xmitab

Conversation

@r-mennig
Copy link
Copy Markdown
Contributor

Currently there is an issue with the search functionality inside of the XMI tab of the E4WorkbenchModelEditor: When searching for a specific text, the search "lags" behind the last entered character and thus only highlights the previously entered text.

SearchLag

This is caused by the search highlighting being recalculated on a keyPressed-Event. This event happens before the text value of the search field is recalculated. In order to fix this issue, the search highlighting should instead react to modification events of the underlying text field (in cases in which the entered character causes the text field to update).

How to reproduce/test:

  1. Create a new application model (or navigate to any existing application model)
  2. Inside the E4WorkbenchModelEditor, select the XMI tab
  3. Select the search field and search for any text shown in the XMI (e.g. "addons") -> The problem happens, the highlighting is always one character behind the search text

I've tried adding some tests for this PR, but I could not find any test plugin for org.eclipse.e4.tools.emf.ui.

image

Should I create a follow-up PR adding a new test plugin with some tests for this PR?

r-mennig and others added 2 commits April 17, 2026 13:28
Consider updated text field after key press when searching in the xmi
tab instead of the out-dated one
@eclipse-pde-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF
e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 62ece08ab882d41e919d2e2857475f49b7f662a2 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Sun, 19 Apr 2026 13:31:54 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF
index 13c6e29331..72e4a7687b 100644
--- a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF
+++ b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.e4.tools.emf.ui;singleton:=true
-Bundle-Version: 4.9.0.qualifier
+Bundle-Version: 4.9.100.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Bundle-RequiredExecutionEnvironment: JavaSE-21
diff --git a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml
index 3f76c7f5f2..8069aec388 100644
--- a/e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml
+++ b/e4tools/bundles/org.eclipse.e4.tools.emf.ui/pom.xml
@@ -21,7 +21,7 @@
 
   <groupId>org.eclipse.platform</groupId>
   <artifactId>org.eclipse.e4.tools.emf.ui</artifactId>
-  <version>4.9.0-SNAPSHOT</version>
+  <version>4.9.100-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
 
   <properties>
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown

Test Results

  147 files  ±0    147 suites  ±0   35m 33s ⏱️ +12s
3 497 tests ±0  3 443 ✅ ±0   54 💤 ±0  0 ❌ ±0 
9 312 runs  ±0  9 182 ✅ ±0  130 💤 ±0  0 ❌ ±0 

Results for commit 53a2832. ± Comparison against base commit 50600c6.

@vogella
Copy link
Copy Markdown
Contributor

vogella commented Apr 19, 2026

LGTM, thanks

@vogella
Copy link
Copy Markdown
Contributor

vogella commented Apr 19, 2026

Follow-up PR with tests would be great.

@vogella vogella merged commit 9a3e908 into eclipse-pde:master Apr 19, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants