Skip to content

Bug 533490 - Find unused dependencies does not respect indirectly referenced class files#9

Closed
HannesWell wants to merge 1 commit intoeclipse-pde:masterfrom
HannesWell:Bug533490
Closed

Bug 533490 - Find unused dependencies does not respect indirectly referenced class files#9
HannesWell wants to merge 1 commit intoeclipse-pde:masterfrom
HannesWell:Bug533490

Conversation

@HannesWell
Copy link
Copy Markdown
Member

This PR resolves Bug 533490

It was first addressed in Eclipse Gerrit Change 138143 but abandoned because it was not completed at the time of the move.

@iloveeclipse you created the mentioned Gerrit as a base for further discussions.
I can try to complete this in the near future and can also check the mentioned performance concerns.

referenced class files

Change-Id: I2fc1bb653d912d3d4be6caa4a3e0430c031cdd5f
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
Signed-off-by: Moritz Aleithe <moritz.aleithe@yahoo.de>
@vogella
Copy link
Copy Markdown
Contributor

vogella commented Aug 9, 2022

@HannesWell could you finish this one? Would be nice to have a "reliable" way to clean up unused dependencies.

@laeubi
Copy link
Copy Markdown
Contributor

laeubi commented Aug 9, 2022

Last time I checked this PDE was actually right and it is more a restriction of the JDT compiler (or PDE) that it do not find transitive dependencies that are not used in the code! OSGi do not require to import those...

@HannesWell
Copy link
Copy Markdown
Member Author

HannesWell commented Aug 9, 2022

@HannesWell could you finish this one? Would be nice to have a "reliable" way to clean up unused dependencies.

Sorry at the moment I don't have the intention to work on this soon. I want to work more on making mixed products work.
Unfortunately I caught Covid as souvenir of my vacation I'm currently sick and can't really work on this. But I hope to complete that before M3.

@vogella
Copy link
Copy Markdown
Contributor

vogella commented Aug 9, 2022

@HannesWell could you finish this one? Would be nice to have a "reliable" way to clean up unused dependencies.

Sorry at the moment I don't have the intention to work on this soon. I want to work more on making mixed products work. Unfortunately I cached Covid as souvenir of my vacation I'm currently sick and can't really work on this. But I hope to complete that before M3.

Gute Besserung, ich hoffe Du hast einen milden Verlauf (loosly translated: all the best to you).

@HannesWell
Copy link
Copy Markdown
Member Author

Gute Besserung, ich hoffe Du hast einen milden Verlauf (loosly translated: all the best to you).

Danke! Mir gings schon besser, aber bin auf dem Weg der Besserung.

@laeubi
Copy link
Copy Markdown
Contributor

laeubi commented Sep 7, 2022

FYI @HannesWell I have created:

let me know if there was already a GH issue. As I plan to work on this, can you give a short update if you have further worked on this or if I should/can base my efforts on your PR?

@HannesWell
Copy link
Copy Markdown
Member Author

let me know if there was already a GH issue.

Not that I'm aware of.

As I plan to work on this, can you give a short update if you have further worked on this or if I should/can base my efforts on your PR?

Yes please go ahead. And no I have not further worked on this one.
I also just transfered this PR from a Gerrit change that was not completed at the time of the migration to GitHub, so I cannot further assist you on that topic.

Let me know if you want to create your own PR and this can be closed. But I'm also fine if you want to push your changes on this one. As you prefer.

@laeubi
Copy link
Copy Markdown
Contributor

laeubi commented Jul 10, 2025

This is now fixed with

@laeubi laeubi closed this Jul 10, 2025
sderazo pushed a commit to JoseRodriguez26/CodedayPDEJ that referenced this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug 533490 - Find unused dependencies does not respect indirectly referenced class files

4 participants