Bug 533490 - Find unused dependencies does not respect indirectly referenced class files#9
Bug 533490 - Find unused dependencies does not respect indirectly referenced class files#9HannesWell wants to merge 1 commit intoeclipse-pde:masterfrom
Conversation
referenced class files Change-Id: I2fc1bb653d912d3d4be6caa4a3e0430c031cdd5f Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Signed-off-by: Moritz Aleithe <moritz.aleithe@yahoo.de>
|
@HannesWell could you finish this one? Would be nice to have a "reliable" way to clean up unused dependencies. |
|
Last time I checked this PDE was actually right and it is more a restriction of the JDT compiler (or PDE) that it do not find transitive dependencies that are not used in the code! OSGi do not require to import those... |
Sorry at the moment I don't have the intention to work on this soon. I want to work more on making mixed products work. |
Gute Besserung, ich hoffe Du hast einen milden Verlauf (loosly translated: all the best to you). |
Danke! Mir gings schon besser, aber bin auf dem Weg der Besserung. |
|
FYI @HannesWell I have created: let me know if there was already a GH issue. As I plan to work on this, can you give a short update if you have further worked on this or if I should/can base my efforts on your PR? |
Not that I'm aware of.
Yes please go ahead. And no I have not further worked on this one. Let me know if you want to create your own PR and this can be closed. But I'm also fine if you want to push your changes on this one. As you prefer. |
|
This is now fixed with |
This PR resolves Bug 533490
It was first addressed in Eclipse Gerrit Change 138143 but abandoned because it was not completed at the time of the move.
@iloveeclipse you created the mentioned Gerrit as a base for further discussions.
I can try to complete this in the near future and can also check the mentioned performance concerns.