Skip to content

Commit bb9a594

Browse files
committed
[I/Y-Build] Replace Base-Builder installation with Tycho eclipse-run
Also remove the (long) unused ant tool, the unused eclipserun-repo property and the now unused ECLIPSE_RUN_REPO environment variable.
1 parent 2456e25 commit bb9a594

8 files changed

Lines changed: 94 additions & 55 deletions

File tree

JenkinsJobs/Builds/build.jenkinsfile

Lines changed: 9 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ pipeline {
2929
tools {
3030
jdk 'temurin-jdk21-latest'
3131
maven 'apache-maven-latest'
32-
ant 'apache-ant-latest'
3332
}
3433
environment {
3534
MAVEN_OPTS = '-Xmx4G'
@@ -174,25 +173,6 @@ pipeline {
174173
}
175174
}
176175
}
177-
stage('Create base builder'){
178-
steps {
179-
script{
180-
def eclipsePlatformLatestRelease = "https://download.eclipse.org/eclipse/downloads/drops4/${PREVIOUS_RELEASE_ID}/eclipse-platform-${PREVIOUS_RELEASE_VER}-linux-gtk-x86_64.tar.gz"
181-
def exe = utilities.installDownloadableTool('eclipse', eclipsePlatformLatestRelease) + '/eclipse'
182-
assignEnvVariable('BASE_BUILDER_ECLIPSE_EXE', "${exe} -nosplash --launcher.suppressErrors")
183-
sh '''
184-
source $CJE_ROOT/buildproperties.shsource
185-
mkdir -p $CJE_ROOT/$TMP_DIR
186-
$BASE_BUILDER_ECLIPSE_EXE \
187-
-debug -consolelog -data $CJE_ROOT/$TMP_DIR/workspace-toolsinstall \
188-
-application org.eclipse.equinox.p2.director \
189-
-repository ${ECLIPSE_RUN_REPO},https://download.eclipse.org/cbi/updates/p2-analyzers/tools/nightly/latest \
190-
-installIU org.eclipse.pde.api.tools,org.eclipse.cbi.p2repo.analyzers.feature.feature.group \
191-
-profile SDKProfile
192-
'''
193-
}
194-
}
195-
}
196176
stage('Aggregator maven build') {
197177
environment {
198178
KEYRING = credentials('secret-subkeys-releng.asc')
@@ -203,6 +183,7 @@ pipeline {
203183
dir("${AGG_DIR}") {
204184
sh '''#!/bin/bash -xe
205185
source $CJE_ROOT/buildproperties.shsource
186+
mkdir -p ${CJE_ROOT}/${TMP_DIR}
206187

207188
mvn clean install -pl :eclipse-sdk-prereqs,:org.eclipse.jdt.core.compiler.batch \
208189
-Dmaven.repo.local=${LOCAL_REPO} -DlocalEcjVersion=99.99 \
@@ -370,30 +351,20 @@ pipeline {
370351
popd
371352

372353
# Generate repository reports
373-
$BASE_BUILDER_ECLIPSE_EXE \
374-
-application org.eclipse.cbi.p2repo.analyzers.repoReport \
375-
-data $CJE_ROOT/$TMP_DIR/workspace-report -vmargs -Xmx1g \
376-
-DreferenceRepo=https://download.eclipse.org/eclipse/updates/${PREVIOUS_RELEASE_REPO_ID}/${BASEBUILD_ID} \
354+
mvn tycho-eclipse:eclipse-run@generate-repo-report -f eclipse-platform-parent \
355+
-Declipserun.workArea=${CJE_ROOT}/${TMP_DIR}/repo-report \
377356
-DreportRepoDir=${PLATFORM_REPO_DIR} \
378357
-DreportOutputDir=${DROP_DIR}/${BUILD_ID}/buildlogs
379358

380359
# Generate API-tools reports
381-
pushd ${DROP_DIR}/${BUILD_ID}
382-
$BASE_BUILDER_ECLIPSE_EXE \
383-
-application org.eclipse.ant.core.antRunner \
384-
-buildfile $ECLIPSE_BUILDER_DIR/eclipse/buildScripts/api-tools-builder.xml \
385-
-data $CJE_ROOT/$TMP_DIR/workspace-apitoolingsLogs \
386-
-DEBuilderDir=$ECLIPSE_BUILDER_DIR \
360+
mvn tycho-eclipse:eclipse-run@generate-api-report -f eclipse-platform-parent \
361+
-Declipserun.workArea=${CJE_ROOT}/${TMP_DIR}/apitoolings-logs \
362+
-DgitRepoRoot=${AGG_DIR} \
387363
-DbuildDirectory=${DROP_DIR}/${BUILD_ID} \
388364
-DbuildId=$BUILD_ID \
389-
-DbuildLabel=$BUILD_ID \
390-
-DbuildWorkingArea=${AGG_DIR} \
391-
-DpreviousBaseURL=https://$DOWNLOAD_HOST/eclipse/downloads/drops4/$PREVIOUS_RELEASE_ID/eclipse-SDK-$PREVIOUS_RELEASE_VER-win32-x86_64.zip \
392-
-DpreviousBaselineName=Eclipse-SDK-$PREVIOUS_RELEASE_VER \
393-
-DpreviousBaselineFilename=eclipse-SDK-$PREVIOUS_RELEASE_VER-win32-x86_64.zip \
394-
-Djava.io.tmpdir=$CJE_ROOT/$TMP_DIR \
395-
apiToolsReports
396-
popd
365+
-DpreviousReleaseVer=${PREVIOUS_RELEASE_VER} \
366+
-DpreviousReleaseId=${PREVIOUS_RELEASE_ID} \
367+
397368
rm -rf ${DROP_DIR}/${BUILD_ID}/apitoolingreference
398369

399370
# Wait for notarization to complete before checksums are generated.

JenkinsJobs/Releng/prepareNextDevCycle.jenkinsfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,6 @@ pipeline {
157157
"STREAM=\".*\"" : "STREAM=\"${NEXT_RELEASE_VERSION}.0\"",
158158
"STREAMMajor=\".*\"" : "STREAMMajor=\"${NEXT_RELEASE_VERSION_MAJOR}\"",
159159
"STREAMMinor=\".*\"" : "STREAMMinor=\"${NEXT_RELEASE_VERSION_MINOR}\"",
160-
"ECLIPSE_RUN_REPO=\".*\"" : "ECLIPSE_RUN_REPO=\"https://download.eclipse.org/eclipse/updates/${NEXT_RELEASE_VERSION}-I-builds/\"",
161160
"NEXT_JAVA_RELEASE_DATE=\".*\"" : "NEXT_JAVA_RELEASE_DATE=\"${NEXT_JAVA_RELEASE_DATE}\"",
162161
])
163162
replaceInFile('products/eclipse-platform/platform.p2.inf', [

JenkinsJobs/Releng/promoteBuild.jenkinsfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -255,9 +255,6 @@ pipeline {
255255
-DnewPrevious-release.baseline="${RELEASE_P2_REPOSITORY}" \
256256
-DnewCbi-ecj-version="${ecjVersion}"
257257
"""
258-
utilities.replaceAllInFile('cje-production/buildproperties.txt', [
259-
'ECLIPSE_RUN_REPO="https://download.eclipse.org/eclipse/updates/.*"' : "ECLIPSE_RUN_REPO=\"${RELEASE_P2_REPOSITORY}\"",
260-
])
261258
utilities.gitCommitAllExcludingSubmodules("Update ${MAINTENANCE_BRANCH} branch with release version for ${BUILD_MAJOR}_${BUILD_MINOR}+ changes")
262259
}
263260
// Switch back to master for subsequent parts of this pipeline

RELEASE.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,6 @@ Previously they were created in ther own job:
148148
This is still a work in progress so if there are any issues or a repo gets missed you can fall back to the old process below:
149149
Once that's done it's easiest to just grep for the previous release version or stream number to find the remaining instances that need to be updated, then commit the changes in a new branch for each repo.
150150
- **Update comparator repo and eclipse run repo**
151-
- Update the ECLIPSE_RUN_REPO in the [cje-production](cje-production) buildproperties.txt files
152151
- **Set Previous Version to RC2**
153152
- RC2 becomes the new baseline for the week before the GA release.
154153
- Update previous-release.baseline in [eclipse-platform-parent/pom.xml](eclipse-platform-parent/pom.xml)

cje-production/buildproperties.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ STREAMMajor="4"
2323
STREAMMinor="40"
2424
STREAMService="0"
2525
TMP_DIR="tmp"
26-
DOWNLOAD_HOST="download.eclipse.org"
2726
NEXT_JAVA_RELEASE_DATE=""
2827

2928
PREVIOUS_RELEASE_VER="4.39"
@@ -32,5 +31,3 @@ PREVIOUS_RELEASE_REPO_ID="4.39"
3231
BASEBUILD_ID="R-4.39-202602260420"
3332
#release id for downloading eclipse
3433
PREVIOUS_RELEASE_ID="R-4.39-202602260420"
35-
36-
ECLIPSE_RUN_REPO="https://download.eclipse.org/eclipse/updates/4.40-I-builds/"

cje-production/mbscripts/mb010_createEnvfiles.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,5 +75,4 @@ fn-addToPropFiles BUILD_ENV_FILE_PROP "\"$BUILD_ENV_FILE_PROP\""
7575
fn-addToPropFiles BUILD_TYPE "\"${BUILD_TYPE}\""
7676
fn-addToPropFiles BUILD_TYPE_NAME "\"${BUILD_TYPE_NAME}\""
7777
fn-addToPropFiles BUILD_ID "\"$BUILD_TYPE$TIMESTAMP\""
78-
fn-addToPropFiles ECLIPSE_BUILDER_DIR "\"$AGG_DIR/eclipse.platform.releng.tychoeclipsebuilder\""
7978
fn-addToPropFiles TEST_CONFIGURATIONS_EXPECTED "\"${TEST_CONFIGURATIONS_EXPECTED}\""

eclipse-platform-parent/pom.xml

Lines changed: 85 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,13 +69,6 @@
6969

7070
<eclipse-sdk-repo>https://download.eclipse.org/eclipse/updates/${releaseVersion}-I-builds/</eclipse-sdk-repo>
7171

72-
<!--
73-
The tycho-eclipserun-plugin will create its instance of Eclipse from this
74-
'eclipiserun-repo' repository, such as for computing .api-descriptions and
75-
generating API Tools reports.
76-
-->
77-
<eclipserun-repo>${eclipse-sdk-repo}</eclipserun-repo>
78-
7972
<comparator.repo>${eclipse-sdk-repo}</comparator.repo>
8073

8174
<!-- only used when Tycho snapshot repo is enabled in <pluginRepositories> further down -->
@@ -495,6 +488,91 @@
495488
<artifactId>tycho-gpg-plugin</artifactId>
496489
<version>${tycho.version}</version>
497490
</plugin>
491+
<plugin>
492+
<groupId>org.eclipse.tycho</groupId>
493+
<artifactId>tycho-eclipse-plugin</artifactId>
494+
<version>${tycho.version}</version>
495+
<configuration>
496+
<work>${eclipserun.workArea}</work>
497+
<repositories>
498+
<repository>
499+
<id>eclipse</id>
500+
<layout>p2</layout>
501+
<url>${eclipse-sdk-repo}</url>
502+
</repository>
503+
</repositories>
504+
</configuration>
505+
<executions>
506+
<execution>
507+
<id>generate-repo-report</id>
508+
<goals>
509+
<goal>eclipse-run</goal>
510+
</goals>
511+
<phase>none</phase><!-- Ensure explict invocation is required. -->
512+
<configuration>
513+
<applicationArgs>
514+
<arg>-application</arg>
515+
<arg>org.eclipse.cbi.p2repo.analyzers.repoReport</arg>
516+
</applicationArgs>
517+
<jvmArgs>
518+
<arg>-DreferenceRepo=${previous-release.baseline}</arg>
519+
<arg>-DreportRepoDir=${reportRepoDir}</arg>
520+
<arg>-DreportOutputDir=${reportOutputDir}</arg>
521+
</jvmArgs>
522+
<dependencies>
523+
<dependency>
524+
<artifactId>org.eclipse.cbi.p2repo.analyzers.feature</artifactId>
525+
<type>eclipse-feature</type>
526+
</dependency>
527+
</dependencies>
528+
<repositories combine.children="append">
529+
<repository>
530+
<id>cbi.p2repo.analyzer</id>
531+
<layout>p2</layout>
532+
<url>https://download.eclipse.org/cbi/updates/p2-analyzers/tools/nightly/latest</url>
533+
</repository>
534+
</repositories>
535+
</configuration>
536+
</execution>
537+
<execution>
538+
<id>generate-api-report</id>
539+
<goals>
540+
<goal>eclipse-run</goal>
541+
</goals>
542+
<phase>none</phase><!-- Ensure explict invocation is required. -->
543+
<configuration>
544+
<applicationArgs>
545+
<arg>-application</arg>
546+
<arg>org.eclipse.ant.core.antRunner</arg>
547+
<arg>-buildfile</arg>
548+
<arg>${gitRepoRoot}/eclipse.platform.releng.tychoeclipsebuilder/eclipse/buildScripts/api-tools-builder.xml</arg>
549+
<arg>apiToolsReports</arg>
550+
</applicationArgs>
551+
<jvmArgs>
552+
<arg>-DEBuilderDir=${gitRepoRoot}/eclipse.platform.releng.tychoeclipsebuilder</arg>
553+
<arg>-DbuildDirectory=${buildDirectory}</arg>
554+
<arg>-DbuildId=${buildId}</arg>
555+
<arg>-DbuildLabel=${buildId}</arg>
556+
<arg>-DbuildWorkingArea=${gitRepoRoot}</arg>
557+
<arg>-DpreviousBaseURL=https://download.eclipse.org/eclipse/downloads/drops4/${previousReleaseId}/eclipse-SDK-${previousReleaseVer}-win32-x86_64.zip</arg>
558+
<arg>-DpreviousBaselineName=Eclipse-SDK-${previousReleaseVer}</arg>
559+
<arg>-DpreviousBaselineFilename=eclipse-SDK-${previousReleaseVer}-win32-x86_64.zip</arg>
560+
<arg>-Djava.io.tmpdir=${env.CJE_ROOT}/${env.TMP_DIR}</arg>
561+
</jvmArgs>
562+
<dependencies>
563+
<dependency>
564+
<artifactId>org.eclipse.pde.api.tools</artifactId>
565+
<type>eclipse-plugin</type>
566+
</dependency>
567+
<dependency>
568+
<artifactId>org.eclipse.platform</artifactId>
569+
<type>eclipse-feature</type>
570+
</dependency>
571+
</dependencies>
572+
</configuration>
573+
</execution>
574+
</executions>
575+
</plugin>
498576
<plugin>
499577
<groupId>org.eclipse.tycho</groupId>
500578
<artifactId>tycho-versions-plugin</artifactId>

eclipse-platform-parent/saveproperties/mavenproperties.properties

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ tycho.localArtifacts=${tycho.localArtifacts}
66
tycho.version=${tycho.version}
77
cbi-ecj-version=${cbi-ecj-version}
88
cbi-plugins.version=${cbi-plugins.version}
9-
eclipserun-repo=${eclipserun-repo}
109

1110
java.class.path=${java.class.path}
1211
java.class.version=${java.class.version}

0 commit comments

Comments
 (0)