[Build] Unify and clean-up eclipse product executable icons

Remove the effectively unused eclipse.ico icon for the Windows
executable, because the executable binary produced by Equinox contains
that icon already by default, which is sufficient.
Unify the name of the linux icon,  too.

Author: HannesWell

eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/icons/eclipse.ico

@@ -23,14 +23,14 @@
    <splash
       location="org.eclipse.platform" />
    <launcher name="eclipse">
-      <linux icon="icons/icon.xpm"/>
+      <linux icon="icons/eclipse.xpm"/>
       <macosx icon="icons/Eclipse.icns">
          <bundleUrlTypes>
             <bundleUrlType scheme="eclipse+command" name="Eclipse Command"/>
          </bundleUrlTypes>
       </macosx>
       <win useIco="false">
-         <bmp/>
+         <bmp/> <!-- Use default branding icon of the eclipse exe for Windows -->
       </win>
    </launcher>
 

…lipse.platform.repository/icons/icon.xpm …se.platform.repository/icons/eclipse.xpmeclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/icons/icon.xpm renamed to eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/icons/eclipse.xpm eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/icons/icon.xpm renamed to eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/icons/eclipse.xpm

@@ -23,10 +23,10 @@
    <splash
       location="org.eclipse.platform" />
    <launcher name="eclipse">
-      <linux icon="icons/icon.xpm"/>
+      <linux icon="icons/eclipse.xpm"/>
       <macosx icon="icons/Eclipse.icns"/>
       <win useIco="false">
-         <bmp/>
+         <bmp/> <!-- Use default branding icon of the eclipse exe for Windows -->
       </win>
    </launcher>
 

eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/platform.product

@@ -18,7 +18,7 @@
    <windowImages/>
 
    <launcher name="rt">
-      <linux icon="icon.xpm"/>
+      <linux icon="rt.xpm"/>
       <macosx icon="rt.icns"/>
       <win useIco="true">
          <ico path="rt.ico"/>