[RelEng] Support multiple working-directories in Version-Increment workflow#3293
Closed
HannesWell wants to merge 1 commit into
Closed
Conversation
Member
Author
|
In general this seems to work, but now fails with Seems like we have to checkout sub-modules too. |
HannesWell
force-pushed
the
multiple-working-directories-in-version-increment-check
branch
2 times, most recently
from
ff2fd63 to
53f8161
Compare
And support the checkout of submodules, on request. Enable the versions within the 'eclipse.platform.releng' and 'eclipse.platform.common' directory in this repositories. The latter requires to checkout submodules.
HannesWell
force-pushed
the
multiple-working-directories-in-version-increment-check
branch
from
53f8161 to
aeee2a6
Compare
Member
Author
|
@laeubi in #3285 (comment) you said, that this would be too complicated. |
Member
Author
|
As this increases the runtime of the version-check for all PRs significantly and the doc bundles are hopefully moved somewhere else on the long run, it seems not valuable enough at the moment. |
HannesWell
deleted the
multiple-working-directories-in-version-increment-check
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And check the versions within the
eclipse.platform.relengandeclipse.platform.commondirectory in this repositories.