4.40 I-Build: I20260512-1800 - BUILD FAILED

[iloveeclipse]

See https://ci.eclipse.org/releng/job/Builds/job/I-build-4.40/108/console

00:23:48  [apitooling.analysis] ==================================================================================
00:23:48  [apitooling.analysis] org.eclipse.equinox.http.jetty : Total: 2 (Usage: 0, Compatibility: 0, Bundle version: 2)
00:23:48  [apitooling.analysis] ==================================================================================
00:23:48  [apitooling.analysis] Bundle Versions:
00:23:48  [apitooling.analysis] The minor version for the package 'org.eclipse.equinox.http.jetty' should be incremented to version 1.6.0, since new APIs have been added since version 1.5.0
00:23:48  [apitooling.analysis] The minor version should be incremented in version 3.9.700, since new APIs have been added since version 3.9.600
00:23:48  [apitooling.analysis] ==================================================================================
00:23:48  [apitooling.analysis] 
00:23:48  
00:23:48  BUILD FAILED
00:23:48  /home/jenkins/agent/workspace/Builds/I-build-4.40/cje-production/gitCache/eclipse.platform.releng.aggregator/scripts/releng/apiReport/builder.xml:51: java.lang.NullPointerException: Cannot invoke "String.compareTo(String)" because the return value of "org.eclipse.pde.api.tools.internal.provisional.problems.IApiProblem.getTypeName()" is null
00:23:48  	at org.eclipse.pde.api.tools.internal.tasks.APIToolsAnalysisTask.lambda$1(APIToolsAnalysisTask.java:557)
00:23:48  	at java.base/java.util.TimSort.countRunAndMakeAscending(TimSort.java:355)
00:23:48  	at java.base/java.util.TimSort.sort(TimSort.java:220)
00:23:48  	at java.base/java.util.Arrays.sort(Arrays.java:1304)
00:23:48  	at java.base/java.util.ArrayList.sortRange(ArrayList.java:1817)
00:23:48  	at java.base/java.util.ArrayList.sort(ArrayList.java:1810)
00:23:48  	at java.base/java.util.Collections.sort(Collections.java:178)
00:23:48  	at org.eclipse.pde.api.tools.internal.tasks.APIToolsAnalysisTask.insertAPIProblems(APIToolsAnalysisTask.java:557)
00:23:48  	at org.eclipse.pde.api.tools.internal.tasks.APIToolsAnalysisTask.dumpReport(APIToolsAnalysisTask.java:228)
00:23:48  	at org.eclipse.pde.api.tools.internal.tasks.APIToolsAnalysisTask.execute(APIToolsAnalysisTask.java:486)
00:23:48  	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:299)
00:23:48  	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
00:23:48  	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
00:23:48  	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
00:23:48  	at org.apache.tools.ant.Task.perform(Task.java:350)
00:23:48  	at org.apache.tools.ant.Target.execute(Target.java:449)
00:23:48  	at org.apache.tools.ant.Target.performTasks(Target.java:470)
00:23:48  	at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1401)
00:23:48  	at org.apache.tools.ant.Project.executeTarget(Project.java:1374)
00:23:48  	at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
00:23:48  	at org.eclipse.ant.internal.core.ant.EclipseDefaultExecutor.executeTargets(EclipseDefaultExecutor.java:34)
00:23:48  	at org.apache.tools.ant.Project.executeTargets(Project.java:1264)
00:23:48  	at org.eclipse.ant.internal.core.ant.InternalAntRunner.run(InternalAntRunner.java:638)
00:23:48  	at org.eclipse.ant.internal.core.ant.InternalAntRunner.run(InternalAntRunner.java:512)
00:23:48  	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
00:23:48  	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
00:23:48  	at org.eclipse.ant.core.AntRunner.run(AntRunner.java:506)
00:23:48  	at org.eclipse.ant.core.AntRunner.start(AntRunner.java:603)
00:23:48  	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:219)
00:23:48  	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:149)
00:23:48  	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:115)
00:23:48  	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:467)
00:23:48  	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:298)
00:23:48  	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
00:23:48  	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
00:23:48  	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:615)
00:23:48  	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:563)
00:23:48  	at org.eclipse.equinox.launcher.Main.run(Main.java:1415)
00:23:48  	at org.eclipse.equinox.launcher.Main.main(Main.java:1387)
00:23:48  
00:23:48  Total time: 33 seconds
00:23:48  An error has occurred. See the log file
00:23:48  /home/jenkins/agent/workspace/Builds/I-build-4.40/cje-production/tmp/apitoolings-logs/data/.metadata/.log.

[iloveeclipse]

It seems API tooling is failing due the signature change in org.eclipse.equinox.http.jetty.JettyConfigurator.startServer(String, Dictionary<String, ?>), see eclipse-jdt/eclipse.jdt.core#2857

[HannesWell]

It seems that at least two new API problems were introduced compared to the previous build:

[apitooling.analysis] ==================================================================================
[apitooling.analysis] org.eclipse.debug.core : Total: 1 (Usage: 0, Compatibility: 0, Bundle version: 1)
[apitooling.analysis] ==================================================================================
[apitooling.analysis] Bundle Versions:
[apitooling.analysis] The minor version should be incremented in version 3.23.300, since new APIs have been added since version 3.23.200
[apitooling.analysis] ==================================================================================

[apitooling.analysis] ==================================================================================
[apitooling.analysis] org.eclipse.equinox.http.jetty : Total: 2 (Usage: 0, Compatibility: 0, Bundle version: 2)
[apitooling.analysis] ==================================================================================
[apitooling.analysis] Bundle Versions:
[apitooling.analysis] The minor version for the package 'org.eclipse.equinox.http.jetty' should be incremented to version 1.6.0, since new APIs have been added since version 1.5.0
[apitooling.analysis] The minor version should be incremented in version 3.9.700, since new APIs have been added since version 3.9.600
[apitooling.analysis] ==================================================================================

But only the second one seems to cause problem, maybe because only the second is in a versioned package?

[iloveeclipse]

I see yet another case in org.eclipse.debug.core, most likely due org.eclipse.debug.core.ILaunchConfigurationWorkingCopy.setAttributes(Map<String, ?>)

Unfortunately we have PDE bug which prevents us to see where exactly API tolling found the problem, see eclipse-pde/eclipse.pde#2332

[iloveeclipse]

@HannesWell : since signature change should not be API issue according to #3814 (comment) and eclipse-jdt/eclipse.jdt.core#2857, I plan to mute API errors via filters.

[iloveeclipse]

With the knowledge of what is causing the problem, one can see the places confused API tooling by searching for ? extends Object in public APi of both bundles.

[HannesWell]

since signature change should not be API issue according to #3814 (comment) and eclipse-jdt/eclipse.jdt.core#2857, I plan to mute API errors via filters.

If that helps, I think it's a prober workaround to get the build working again. Thanks!

With the knowledge of what is causing the problem, one can see the places confused API tooling by searching for ? extends Object in public APi of both bundles.

And one should also be able to replicate the issue by just removing the filters again locally.

[iloveeclipse]

If that helps,

The assumption is that the code which runs into NPE doesn't see the problem because it should be filtered out.
See org.eclipse.pde.api.tools.internal.tasks.APIToolsAnalysisTask.execute() where it should apply filters.

Call tree

org.eclipse.pde.api.tools.internal.tasks.APIToolsAnalysisTask.Summary.apiBundleVersionProblems
org.eclipse.pde.api.tools.internal.tasks.APIToolsAnalysisTask.dumpReport(Summary[], List<String>, Map<String, Object>)
org.eclipse.pde.api.tools.internal.tasks.APIToolsAnalysisTask.Summary.getDetails()
org.eclipse.pde.api.tools.internal.tasks.APIToolsAnalysisTask.Summary.printTitle(PrintWriter)
org.eclipse.pde.api.tools.internal.tasks.APIToolsAnalysisTask.Summary.Summary(String, IApiProblem[])
org.eclipse.pde.api.tools.internal.tasks.APIToolsAnalysisTask.createProblemSummary(String, IApiProblem[])
org.eclipse.pde.api.tools.internal.tasks.APIToolsAnalysisTask.createAllSummaries(Map<String, IApiProblem[]>)
org.eclipse.pde.api.tools.internal.tasks.APIToolsAnalysisTask.execute()

[iloveeclipse]

The fix for NPE is eclipse-pde/eclipse.pde#2333