Automatic version bump job is not working

[iloveeclipse]

Seen already on almost all SDK repositories.

There workflow Check and increment service versions configured to automatically bump manifest versions on the first change in the release stopped to work in 4.41.

Latest example: eclipse-platform/eclipse.platform#2811

Here the log from failure. Looks like committing the change doesn't work anymore (or following task)?

Run set -x
+ git add '*/META-INF/MANIFEST.MF'
+ git add '*/feature.xml'
+ git add '*/pom.xml'
++ git diff --name-only --cached
+ [[ ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF != '' ]]
+ pushd .
+ mvn help:evaluate -Dexpression=releaseNumberSDK --quiet -Doutput=streamVersion-value.txt
~/work/eclipse.platform/eclipse.platform ~/work/eclipse.platform/eclipse.platform
+ streamVersion=4.41
+ rm -f streamVersion-value.txt
+ popd
+ git config --global user.email platform-bot@eclipse.org
~/work/eclipse.platform/eclipse.platform
+ git config --global user.name 'Eclipse Platform Bot'
+ git status
HEAD detached at pull/2811/merge
Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
	modified:   ant/org.eclipse.ant.ui/META-INF/MANIFEST.MF
+ git commit -m 'Version bump(s) for 4.41 stream'
[detached HEAD 4e8f26e56b] Version bump(s) for 4.41 stream
 1 file changed, 1 insertion(+), 1 deletion(-)
+ git format-patch -1 HEAD --no-stat --output version_increments.patch
+ echo 2811
+ echo '::error title=Version increments are missing::Required version increments are missing and a commit to apply them is about to be pushed to your PR'\''s branch.'
+ exit 1
Error: Required version increments are missing and a commit to apply them is about to be pushed to your PR's branch.
Error: Process completed with exit code 1.

[MohananRahul]

It looks like the failure occurred in the GitHub Actions run: https://github.com/eclipse-platform/eclipse.platform/actions/runs/29231489111.

The workflow appears to require allow-unsafe-pr-checkout: true. With actions/checkout@v7, using github.event.workflow_run.head_sha requires the explicit opt in by setting allow-unsafe-pr-checkout: true. cc : @HannesWell

[merks]

@MohananRahul

If you know how to fix this or think you know how to fix this, it would be really good to fix this. Given that @HannesWell is on vacation, we shouldn't expect so much. This problem is super annoying, and I hate to have to explain it to users, e.g.,

eclipse-equinox/p2#1103

[HannesWell]

The workflow appears to require allow-unsafe-pr-checkout: true. With actions/checkout@v7, using github.event.workflow_run.head_sha requires the explicit opt in by setting allow-unsafe-pr-checkout: true.

Doing that seems save to me since the GH-Token issued by default has no permissions:

eclipse.platform.releng.aggregator/.github/workflows/publishVersionCheckResults.yml

Line 15 in c5ef194

permissions: {} # all none

Furthermore none of the checked out files should be executed, only the patch should be applied and pushed.

However, I'm only on my phone at the moment and cannot check it in detail or fix it. But setting the suggested property should fix it. Just be careful to use only the correct amount of spaces for indentation since yaml is very picky.