[Build|GH] Add quick-fix to avoid need for EF-infrastrucutre#2997
Merged
HannesWell merged 1 commit intoeclipse-platform:masterfrom Apr 26, 2025
Merged
[Build|GH] Add quick-fix to avoid need for EF-infrastrucutre#2997HannesWell merged 1 commit intoeclipse-platform:masterfrom
HannesWell merged 1 commit intoeclipse-platform:masterfrom
Conversation
This was referenced Apr 26, 2025
HannesWell
commented
Apr 26, 2025
HeikoKlare
approved these changes
Apr 26, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Great workaround, thank you! 🚀
The change looks good and seems to work (as you show at the platform.ui repo). I only found a nitpicky typo, which you might fix in all three workflows when exchanging the organization name for the used action for final submission.
HannesWell
force-pushed
the
gh-workflow-quickfix
branch
from
ed6f684 to
d91eb7d
Compare
Member
Author
|
Thank you. I'm looking forward too!
I just made the final adjustments to use the final repo and branch name, so this is ready for submission. |
1 task
HannesWell
added a commit
to HannesWell/eclipse.platform.releng.aggregator
that referenced
this pull request
May 1, 2025
This reverts commit 420686a added in - eclipse-platform#2997
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to mitigate the current outage of the EF-hosted storage, which will probably continue to block builds for at least a few days (https://www.eclipse.org/lists/eclipse.org-committers/msg01493.html) this implements a quick-fix to avoid the need for said EF infrastructure for the shared GitHub workflows. This is achieved by the following actions:
Especially the latter could cause problems for builds that rely on the new features only available in Tycho 4.0.13-SNAPSHOT. Therefore this is currently designed as opt-in feature. But looking at #2870 (comment), only SWT currently needs the snapshot but doesn't use the shared workflow.
After some more testing we could also enable this by default.