Add terminal control to update site#3023
Conversation
Since we migrated it from CDT, there should be a way for CDT to get rid of this bundle. Adding it to the update site would allow this without platform explicitly referencing it (yet).
|
/request-license-review |
Workflow run (with attached summary files): |
|
The license check likley fails because we need an ibuild to update the branch pointers?! As Jenkins succeed I think it can be merged. |
|
Shouldn't it be added to some features/products as well? |
|
@mickaelistria this will be automatically pulled by features/products once there is a reference so there is usually no need to explicitly include it. |
|
Moreover, CDT currently has its own version that is included in a feature so, given this bundle is a singleton, so we need to be careful during the transition period that there isn't more than one feature including it because if those includes are of different versions, the two feature could not both be installed. FYI @jonahgraham |
What is the dependency chain that includes it eg in the Eclipse SDK product right now? |
As far as I can see latest nightly SDK doesn't include org.eclipse.tm.terminal.control. |
|
Nothing includes it yet. So indeed, it's not in the product, yet either. That's why it's added to the category.xml directly, like is the case for other bundles mentioned directly in the category.xml, e.g., |
|
If someone is interested in the current POC it can be found here: I hope to finish this for this release but maybe it is only used in the next release (2025-09) depending on how it works out as we need some coordination with CDT. |
4 participants
Since we migrated it from CDT, there should be a way for CDT to get rid of this bundle. Adding it to the update site would allow this without platform explicitly referencing it (yet).