Skip to content

Escape message/code of compile logs and adapt filename in build website #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HannesWell merged 1 commit into from
Jan 15, 2026
Merged

Escape message/code of compile logs and adapt filename in build website #3612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/releng/CompilerSummaryGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
/** @author Dean Roberts (circa 2000!) and David Williams (circa 2016) */

final String XML_EXTENSION = ".xml";
final String COMPILER_SUMMARY_FILENAME = "compilerSummary.json";
final String COMPILER_SUMMARY_FILENAME = "logs.json";

Path compileLogsDirectory; // Location of compile logs base directory

Expand Down
8 changes: 4 additions & 4 deletions sites/eclipse/build/tests.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,13 +186,13 @@ <h3 id="compiler-issues">Plugins containing compile warnings or infos</h3>
severity = problem.getAttribute('severity')
const problemID = problem.getAttribute('id')
const line = parseInt(problem.getAttribute('line'))
const message = problem.querySelector('message').getAttribute('value')
const message = escapeHTML(problem.querySelector('message').getAttribute('value'))
const contextValue = problem.querySelector('source_context').getAttribute('value')
const sourceStart = parseInt(problem.querySelector('source_context').getAttribute('sourceStart'))
const sourceEnd = parseInt(problem.querySelector('source_context').getAttribute('sourceEnd')) + 1
const sourceCodeBefore = contextValue.substring(0, sourceStart)
const sourceCode = contextValue.substring(sourceStart, sourceEnd);
const sourceCodeAfter = contextValue.substring(sourceEnd, contextValue.length);
const sourceCodeBefore = escapeHTML(contextValue.substring(0, sourceStart))
const sourceCode = escapeHTML(contextValue.substring(sourceStart, sourceEnd))
const sourceCodeAfter = escapeHTML(contextValue.substring(sourceEnd, contextValue.length))
if (isMatchingIssue(issueType, severity, problemID)) {
elements += `
<tr class="no-zebra-striping">
Expand Down
7 changes: 7 additions & 0 deletions sites/eclipse/page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,13 @@ function prependChildren(element, id, ...children) {
return element;
}

function escapeHTML(rawString) {
return rawString
.replaceAll('&', '&amp;')
.replaceAll('<', '&lt;')
.replaceAll('>', '&gt;')
}

// Collapsibles/accordion tables

let _eventListenersAdded = false
Expand Down
Loading