[Build] Remove unnecessary resources-plugin executions and set encoding#3756
Merged
HannesWell merged 1 commit intoApr 11, 2026
Merged
Conversation
Member
Author
|
I found one actual usage of the removed execution: But since that project has packaging type ... which should be suitable for the project's content: Therefore the removal should still be fine. |
Java properties files are encoded using ISO-8859-1 encoding. Therefore, when filtered by the maven-resources-plugin, these files should be written with that encoding. Explicit specifying the encoding also prevents the following INFO log ''' The encoding used to copy filtered properties files has not been set. This means that the same encoding will be used to copy filtered properties files as when copying other filtered resources. This might not be what you want! Run your build with --debug to see which files might be affected. Read more at https://maven.apache.org/plugins/maven-resources-plugin/examples/filtering-properties-files.html '''
e6597cc to
14b9035
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
filter-resourcesexecution of themaven-resources-pluginseems not any effect at any project and the specified directory is always just skipped.Additionally specify the the encoding explicitly when filtering resources, to prevent the INFO from below.
Java properties files are encoded using ISO-8859-1 encoding. Therefore, when filtered by the
maven-resources-plugin, these files should be written with that encoding.