[I/Y-Build] Streamline environment variable computation and export#3757
Merged
HannesWell merged 1 commit intoeclipse-platform:masterfrom Apr 15, 2026
Merged
Conversation
HannesWell
force-pushed
the
streamline-env-variable-handling
branch
2 times, most recently
from
b3ec8f6 to
67a1b47
Compare
Replace common-functions.shsource and buildproperties.shsource and mb010_createEnvfiles.sh script. Remove quotes around values in 'buildproperties' files.
HannesWell
force-pushed
the
streamline-env-variable-handling
branch
from
67a1b47 to
0679b1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid need for
common-functions.shsourceandbuildproperties.shsource.Replace
mb010_createEnvfiles.shscript and remove quotes around values inbuildproperties.*files.The former removes the now respectively longer unused
buildproperties.shsourceandbuildproperties.phpfiles from the produced build drops.Additionally the
mavenproperties.propertiesis now removed from future build drops, instead its values are included into the generatedbuildproperties.properties.This is currently a draft since the base-builder needs values of variables from Maven, which are only exported after the main Maven build. Either the creation of the base-builder has to be moved after the main build or has to be replaced.I'm currently working on the latter, replacing it with invocations of
tycho-eclipse:eclipse-run.Eventually this was done with: