[I/Y-Build] Generalize API report generation and fix website links to it#3773
Conversation
| # Collect .api_filters files | ||
| for filter in $(find ${AGG_DIR} -type f -path '*/.settings/.api_filters'); do | ||
| IFS='/' read -ra PATH_SEGMENTS <<< "${filter}" | ||
| pluginName="${PATH_SEGMENTS[-3]}" | ||
| target=${DROP_DIR}/${BUILD_ID}/apifilters/${pluginName} | ||
| target=${TEMP_DIR}/apifilters/${pluginName} | ||
| mkdir -p ${target} | ||
| cp ${filter} ${target} | ||
| done |
There was a problem hiding this comment.
If the API-problem suppression would be done through annotations, collecting the .api-filters files wouldn't be necessary at all:
There was a problem hiding this comment.
What about suppressions for Manifest.mf files? E.g. version bumps .
There was a problem hiding this comment.
See eclipse-pde/eclipse.pde#2291 (comment).
Lets discuss that there.
For now this part of the script has to stay anyways.
| ## SPECIAL CASE FOR SWT: THE FRAGMENT IS ANALYZED AS PART OF THE HOST | ||
| org.eclipse.swt.win32.win32.x86_64 |
There was a problem hiding this comment.
The API filters for the SWT fragments are currently not considered.
I have to investigate why.
Enhances the API analysis report with the following aspects: - Compare the entire Eclipse repository not just the SDK product for Windows-x86_64 - Move scripts to a more fitting location - Remove filters from build websites as they can be looked up in the SCM - Fix the previously broken links from the Eclipse build websites to the exclusions file
HannesWell
force-pushed
the
generalize-api-report-generation
branch
from
a7df9e7 to
3965870
Compare
| ## SPECIAL CASE FOR SWT: THE FRAGMENT IS ANALYZED AS PART OF THE HOST | ||
| org.eclipse.swt.cocoa.macosx.aarch64 | ||
| org.eclipse.swt.cocoa.macosx.x86_64 | ||
| org.eclipse.swt.gtk.linux.aarch64 | ||
| org.eclipse.swt.gtk.linux.ppc64le | ||
| org.eclipse.swt.gtk.linux.riscv64 | ||
| org.eclipse.swt.gtk.linux.x86_64 | ||
| org.eclipse.swt.win32.win32.aarch64 | ||
| org.eclipse.swt.win32.win32.x86_64 |
There was a problem hiding this comment.
I'm in doubt that the host org.eclipse.swt bundle is actually analyzed. At the same time, the supplied .api_filters files are also not correctly considered.
Therefore I'll leave this state as it is for now and postpone that investigation to a later point in time.
2 participants
Enhances the API analysis report with the following aspects:
apitooling.apideprecationtask fails:[Build] Remove test Plug-ins from Eclipse P2-repository #3772