Add skija to the target platform#3800
Conversation
|
Hello @merks I did now the following: clone your repo and checked out the releng. There load the target :
Next, in the manifest of org.eclipse.swt.skia i set dependencies:
But there i can add shared, types and **for all the OS dependent only the source jars, not the real OS-dependent jars. The OS-dependent jars won't be found. And then if i execute the SnippetCanvasCompare from /org.eclipse.swt.examples (in my skia branch), the library for windows won't be loaded: java.lang.UnsatisfiedLinkError: Library file skija.dll not found in io/github/humbleui/skija/windows/x64/ Am i doing something wrong? |
|
You cannot generally add a requirement to a fragment so it will not be listed when editing the MANIFEST.MF. For SWT folks added requirements from to host to each fragment so the right fragment is typically added to the launch. So these two do that:
That's not been done for skija (in the bundle that requires the skija shared host bundle, it should do something analogous with filtered requirements on each of the os/arch combinations) so it's highly likely that you need to manually add it to the launch. But if it's a-stand alone launch, it's not so easy to add a jar.
But I'd tried that first just for quick feedback... I guess you need help with this, but I don't know how to reproduce your setup to provide such help (and I have limited time). The p2.inf should have stuff like this, one per supported os/arch: Each combination needs a new number, e.g., requires.2., requires.3. General docs: https://eclipse.dev/eclipse/markdown/?file=eclipse-equinox/p2/master/docs/Customizing_Metadata.md |
|
Hello @merks I just wanted to check whether i get the native libs somehow to run. Now in the project explorer i imported: -> To SWT i added in the manifest all humbleui bundles and reexported them. requires.10.namespace = org.eclipse.equinox.p2.iu But maven install for org.eclipse.swt fails, because the skija dependencies won't be found by the standard tycho build: [INFO] �[1m------------------------------------------------------------------------�[m -> to examples i added a new snippet, which uses skija: No syntax error. the code will be executed, but the skia windows lib won't be found: Exception in thread "main" java.lang.UnsatisfiedLinkError: Library file skija.dll not found in io/github/humbleui/skija/windows/x64/ I have no idea how i can fix this, resp make this run. ... |
|
@merks These are in the classpath.
The native jars are not there. Maybe we have to setup a meeting. |
|
@merks Adding the windows skija jar to the launch configuration was not possible, because at the location you described is a folder not the jar. But i added the windows skija jar as implicit dependency in the target and then the windows fragment was found and the skia fragment worked.
Is this ok for you? |
|
Oh, sorry... yes. This also works. |















No description provided.