Skip to content

Remove jsvg-systemlogger#3807

Merged
merks merged 1 commit into
eclipse-platform:masterfrom
merks:pr-remove-jsvg-systemlogger
May 6, 2026
Merged

Remove jsvg-systemlogger#3807
merks merged 1 commit into
eclipse-platform:masterfrom
merks:pr-remove-jsvg-systemlogger

Conversation

@merks
Copy link
Copy Markdown
Contributor

@merks merks commented May 6, 2026

No description provided.

@merks
Copy link
Copy Markdown
Contributor Author

merks commented May 6, 2026

FYI @HeikoKlare

This build does not appear to be using the latest SWT commit.

Error: Cannot satisfy dependency: org.eclipse.swt.svg 3.132.100.qualifier depends on: java.package; com.github.weisj.jsvg.view [2.0.0,3.0.0)

The actual current lower bound is 2.1.0:

https://github.com/eclipse-platform/eclipse.platform.swt/blob/c1fd7a0bcb45191bfdd5293834cb852fddf3662e/bundles/org.eclipse.swt.svg/META-INF/MANIFEST.MF#L11-L14

I guess we need a real successful I-build to make progress here. Is that correct @HannesWell?

@HeikoKlare
Copy link
Copy Markdown
Contributor

Great. Should we just kick off another I-Build? Even though the one from today failed because the test jobs were not started, the artifacts were still deployed: https://download.eclipse.org/eclipse/updates/4.40-I-builds/I20260506-0618/
We may do that again so that we can proceed with this PR.

@merks
Copy link
Copy Markdown
Contributor Author

merks commented May 6, 2026

Hmmm. I did kick off a build but I see here now that the verification build passed. So only the license check uses the old content from an I-build.

So I think I just merge this, abort the I-build and start a new one.

@merks merks merged commit ca5997c into eclipse-platform:master May 6, 2026
5 of 6 checks passed
@merks merks deleted the pr-remove-jsvg-systemlogger branch May 6, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants