Skip to content

Improve downloads website styling with dark mode and wider layout#3821

Open
vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:master
Open

Improve downloads website styling with dark mode and wider layout#3821
vogella wants to merge 1 commit into
eclipse-platform:masterfrom
vogella:master

Conversation

@vogella

@vogella vogella commented May 14, 2026

Copy link
Copy Markdown
Contributor

Extends sites/eclipse/page.css with a CSS-variable palette (Eclipse-blue accent), automatic dark mode via prefers-color-scheme, Inter and JetBrains Mono typography, card-style tables with larger headers, card-shaped details/accordions and a gradient-stripe popup dialog.

Replaces the section info marker emoji with a FontAwesome fa-solid fa-circle-info icon for a consistent, OS-independent look.

Widens the content container to 1600px and adjusts the main/TOC column split to 80/20 so wide tables have more room.

HTML markup, JSON schema and the build pipeline are untouched.

Fixes #3812

@HannesWell

Copy link
Copy Markdown
Member

Extends sites/eclipse/page.css with a CSS-variable palette (Eclipse-blue accent), automatic dark mode via prefers-color-scheme, Inter and JetBrains Mono typography, card-style tables with larger headers, card-shaped details/accordions and a gradient-stripe popup dialog.

Generally I don't think its good to more than double, almost triple the size of the CSS file. As mentioned in #3812 (comment) one goal is simplicity or at least to make it not too complex.
Would it be possible to leave out few new details to make this significantly simpler?

Inter and JetBrains Mono typography

I have to say that I don't see a noticeable difference between the fonts. But generally it seems to be smaller, especially the titles, which now seem to be even smaller than the following paragraph text.

Replaces the section info marker emoji with a FontAwesome fa-solid fa-circle-info icon for a consistent, OS-independent look.

Please move this into a separate PR. In #3812 (comment) I described the drawbacks of using FontAwesome (of course it has advantages).
But I'm still not sure if this is the overall better solution.
In fact these icons where used in a previous version, which the git history should show. I changed that for the current solution, but that also isn't ideal in all aspects.

Widens the content container to 1600px and adjusts the main/TOC column split to 80/20 so wide tables have more room.

This should also discussed separately. With that applied the TOC looks squashed on long lines like the one for checksums. To solve that a mechanism could be implemented to show a shorter title in the TOC than at the actual section (in that case e.g. just Checksums and Signatures).

Extend sites/eclipse/page.css with a CSS-variable palette (Eclipse-blue
accent), automatic dark mode via prefers-color-scheme, Inter and
JetBrains Mono typography, card-style tables with larger headers,
card-shaped details/accordions and a gradient-stripe popup dialog.

HTML markup, JSON schema and the build pipeline are untouched.

Fixes eclipse-platform#3812
@vogella

vogella commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

Would it be possible to leave out few new details to make this significantly simpler?

Done

Icon and Font changes also removed from the PR.

Widens the content container to 1600px

Also removed from the chnage

@vogella

vogella commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@HannesWell is your feedback addressed?

@HannesWell

Copy link
Copy Markdown
Member

is your feedback addressed?

In my opinion this is still a lot of extra complexity and I would be in favor if it could be done simpler.
It doesn't have to be a net zero change, but in general I think that simplicity is preferred over visual beauty. This page targets rather technical people and is probably not visited by a wider audience of users (like for example https://eclipseide.org/ is).
I'm not even sure how one can reach https://download.eclipse.org/eclipse/ if one doesn't know it?
In that regard I think it's similar to pages like https://openjdk.org/ or https://jdk.java.net/26 and these sites are, while technically interesting and useful, visually not sophisticated.

That being said, if we still want to have this, I have to review this in detail and we should further fine tune this.
I assume you are mainly interested in the dark mode?
I did a quick check and for my taste the table headers are a bit too bright and my eyes try to find a difference with the background, which makes it unpleasent to look at. I know that's probably pretty subjective, but we are discussing visuals here. :)
I also checked the dark mode and headlines are impossible to read and the bright header doesn't match.

Have you tried out/tested the changes locally?
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/tree/53c0ae09eb9a47860540f14786f6876c6b36819e/sites/eclipse#local-testing
We should not figure this out in production.

Maybe it's simpler to discuss and review if the changes for the dark mode and common rework of colors and styles are separated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update download page

2 participants