Skip to content

Commit 1603edd

Browse files
HeikoKlareclaude
andcommitted
[Cocoa] Remove deprecated scroller part constants
NSScrollerDecrementLine and NSScrollerIncrementLine are deprecated since macOS 10.14 without replacement, as scrollers do not have arrow buttons anymore since macOS 10.7. Remove the constants together with the dead switch cases in ScrollBar and Slider that handled hits on the no longer existing scroller arrows. Contributes to #3214 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent a99cbe4 commit 1603edd

4 files changed

Lines changed: 0 additions & 20 deletions

File tree

bundles/org.eclipse.swt/Eclipse SWT PI/cocoa/org/eclipse/swt/internal/cocoa/AppKitFull.bridgesupport.extras

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4517,9 +4517,7 @@
45174517
<enum name="NSRoundLineJoinStyle" swt_gen="true"></enum>
45184518
<enum name="NSScrollElasticityNone" swt_gen="true"></enum>
45194519
<enum name="NSScrollWheel" swt_gen="true"></enum>
4520-
<enum name="NSScrollerDecrementLine" swt_gen="true"></enum>
45214520
<enum name="NSScrollerDecrementPage" swt_gen="true"></enum>
4522-
<enum name="NSScrollerIncrementLine" swt_gen="true"></enum>
45234521
<enum name="NSScrollerIncrementPage" swt_gen="true"></enum>
45244522
<enum name="NSScrollerKnob" swt_gen="true"></enum>
45254523
<enum name="NSScrollerKnobSlot" swt_gen="true"></enum>

bundles/org.eclipse.swt/Eclipse SWT PI/cocoa/org/eclipse/swt/internal/cocoa/OS.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2291,9 +2291,7 @@ public static Selector getSelector (long value) {
22912291
public static final int NSRoundLineJoinStyle = 1;
22922292
public static final int NSScrollElasticityNone = 1;
22932293
public static final int NSScrollWheel = 22;
2294-
public static final int NSScrollerDecrementLine = 4;
22952294
public static final int NSScrollerDecrementPage = 1;
2296-
public static final int NSScrollerIncrementLine = 5;
22972295
public static final int NSScrollerIncrementPage = 3;
22982296
public static final int NSScrollerKnob = 2;
22992297
public static final int NSScrollerKnobSlot = 6;

bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/ScrollBar.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -481,18 +481,10 @@ void sendSelection () {
481481
int hitPart = (int)((NSScroller)view).testPart(point);
482482
Event event = new Event();
483483
switch (hitPart) {
484-
case OS.NSScrollerDecrementLine:
485-
value -= increment;
486-
event.detail = SWT.ARROW_UP;
487-
break;
488484
case OS.NSScrollerDecrementPage:
489485
value -= pageIncrement;
490486
event.detail = SWT.PAGE_UP;
491487
break;
492-
case OS.NSScrollerIncrementLine:
493-
value += increment;
494-
event.detail = SWT.ARROW_DOWN;
495-
break;
496488
case OS.NSScrollerIncrementPage:
497489
value += pageIncrement;
498490
event.detail = SWT.PAGE_DOWN;

bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Slider.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -333,18 +333,10 @@ void sendSelection () {
333333
int hitPart = (int)((NSScroller)view).hitPart();
334334
int value = getSelection ();
335335
switch (hitPart) {
336-
case OS.NSScrollerDecrementLine:
337-
event.detail = SWT.ARROW_UP;
338-
value -= increment;
339-
break;
340336
case OS.NSScrollerDecrementPage:
341337
value -= pageIncrement;
342338
event.detail = SWT.PAGE_UP;
343339
break;
344-
case OS.NSScrollerIncrementLine:
345-
value += increment;
346-
event.detail = SWT.ARROW_DOWN;
347-
break;
348340
case OS.NSScrollerIncrementPage:
349341
value += pageIncrement;
350342
event.detail = SWT.PAGE_DOWN;

0 commit comments

Comments
 (0)