Skip to content

Commit 5d4df79

Browse files
committed
[Edge] Allow SSO with primary account by default
The WebView feature to allow SSO has been made accessible but disabled by default. With this change, the feature is enabled by default, still allowing to opt-out via system property. This aligns with the previous behavior of the IE engine. Fixes #2658
1 parent f20619c commit 5d4df79

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

bundles/org.eclipse.swt/Eclipse SWT Browser/win32/org/eclipse/swt/browser/Edge.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -611,7 +611,7 @@ WebViewEnvironment createEnvironment() {
611611
String browserArgs = System.getProperty(BROWSER_ARGS_PROP);
612612
String language = System.getProperty(LANGUAGE_PROP);
613613

614-
boolean allowSSO = Boolean.getBoolean(ALLOW_SINGLE_SIGN_ON_USING_OS_PRIMARY_ACCOUNT_PROP);
614+
boolean allowSSO = !"false".equalsIgnoreCase(System.getProperty(ALLOW_SINGLE_SIGN_ON_USING_OS_PRIMARY_ACCOUNT_PROP));
615615

616616
String dataDir = getDataDir(display);
617617

bundles/org.eclipse.swt/Readme.WebView2.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,9 @@ language+country code that defines the browser UI language and preferred
6767
language for HTTP requests (`Accept-Languages` header).
6868
Example values: `en`, `ja`, `en-GB`, `de-AT`.
6969

70-
The property `org.eclipse.swt.browser.Edge.allowSingleSignOnUsingOSPrimaryAccount` enables Single Sign-On with Azure Active Directory (AAD) resources using the logged-in Windows account. This also enables SSO with websites using Microsoft accounts associated with the Windows login. Setting this property to true enables this feature. The default value is false.
70+
The WebView2 runtime in SWT automatically enables Single Sign-On with Azure Active Directory (AAD) resources using the logged-in Windows account.
71+
This also enables SSO with websites using Microsoft accounts associated with the Windows login.
72+
This feature can be disabled by setting the system property `org.eclipse.swt.browser.EdgeAllowSingleSignOnUsingOSPrimaryAccount` to `false`.
7173

7274
See also: https://learn.microsoft.com/en-us/dotnet/api/microsoft.web.webview2.core.corewebview2environmentoptions.allowsinglesignonusingosprimaryaccount
7375

0 commit comments

Comments
 (0)