[Mac] Buttons with font sizes>23pt are not correctly rendered #3085

Fix the issue by handling the case when a button uses a custom font with
size > 16pt. In this case adjust the button height in
cellSizeForBounds(), similar to the other height adjustment fixes
already present.

Signed-off-by: Stefan Winkler <stefan@winklerweb.net>

Author: xpomul

bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Button.java

@@ -151,6 +151,16 @@ NSSize cellSizeForBounds (long id, long sel, NSRect cellFrame) {
 		size.height = Math.max(size.height, imageSize.height);
 	}
 
+	// native buttons always return a height of 24.0; a font size higher than 16pt is not reflected.
+	// Therefore, we adjust the button height manually, if a custom font with a size > 16 is set.
+	if (font != null && font.handle.pointSize() > 16.0) {
+		NSCell cell = new NSCell (id);
+		NSRect titleRect = cell.titleRectForBounds(cellFrame);
+		// for some reason, the titleRectForBounds() returns too small heights for font sizes > 20
+		final int FONT_SIZE_HEIGHT_ADJUST = 8;
+		size.height = Math.max(size.height, titleRect.height + FONT_SIZE_HEIGHT_ADJUST);
+	}
+
 	if (((style & (SWT.PUSH|SWT.TOGGLE)) !=0) && (style & (SWT.FLAT|SWT.WRAP)) == 0) {
 		if (image != null) {
 			NSCell cell = new NSCell(id);