Skip to content

Commit 971ec6c

Browse files
vogellaclaude
andcommitted
Remove gtk_toolbar_set_show_arrow from setBounds and GTK3 bindings
Address review feedback: also remove the show_arrow toggle from setBounds, since WRAP is not supported on GTK and the flag was being misused. With no remaining callers, remove the gtk_toolbar_set_show_arrow native binding from GTK3.java as well. Remove Snippet395 as it is a test aid, not a user-facing example. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 29468e1 commit 971ec6c

3 files changed

Lines changed: 0 additions & 107 deletions

File tree

  • bundles/org.eclipse.swt
    • Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk3
    • Eclipse SWT/gtk/org/eclipse/swt/widgets
  • examples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets

bundles/org.eclipse.swt/Eclipse SWT PI/gtk/org/eclipse/swt/internal/gtk3/GTK3.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -702,11 +702,6 @@ public class GTK3 {
702702
* @param item cast=(GtkToolItem *)
703703
*/
704704
public static final native void gtk_toolbar_insert(long toolbar, long item, int pos);
705-
/**
706-
* @param toolbar cast=(GtkToolbar *)
707-
* @param show_arrow cast=(gboolean)
708-
*/
709-
public static final native void gtk_toolbar_set_show_arrow(long toolbar, boolean show_arrow);
710705
/**
711706
* @param toolbar cast=(GtkToolbar *)
712707
* @param style cast=(GtkToolbarStyle)

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ToolBar.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -593,18 +593,8 @@ void reskinChildren (int flags) {
593593

594594
@Override
595595
int setBounds (int x, int y, int width, int height, boolean move, boolean resize) {
596-
if (!GTK.GTK4) GTK3.gtk_toolbar_set_show_arrow (handle, false);
597596
int result = super.setBounds (x, y, width, height, move, resize);
598597
if ((result & RESIZED) != 0) relayout ();
599-
if ((style & SWT.WRAP) != 0) {
600-
if (GTK.GTK4) {
601-
/* TODO: GTK4 will require us to implement our own
602-
* overflow menu. May require the use of the "toolbar" style class
603-
* applied to the widget. */
604-
} else {
605-
GTK3.gtk_toolbar_set_show_arrow (handle, true);
606-
}
607-
}
608598

609599
return result;
610600
}

examples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet395.java

Lines changed: 0 additions & 92 deletions
This file was deleted.

0 commit comments

Comments
 (0)