Do not call addListener in constructor of Item #2733

fedejeanne · fedejeanne · commit 9e2bdb5b5c69 · 2025-11-05T15:06:12.000+01:00
The method is not final, which may cause issues if a subclass overrides it because it ends up being called upon instantiation, when the object is not fully initialized Fixes #2733
diff --git a/bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/widgets/Item.java b/bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/widgets/Item.java
@@ -75,7 +75,7 @@ public abstract class Item extends Widget {
 public Item (Widget parent, int style) {
 	super (parent, style);
 	text = "";
-	this.addListener(SWT.ZoomChanged, this::handleDPIChange);
+	this._addListener(SWT.ZoomChanged, this::handleDPIChange);
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public abstract class Item extends Widget {`
`75`	`75`	`public Item (Widget parent, int style) {`
`76`	`76`	`super (parent, style);`
`77`	`77`	`text = "";`
`78`		`- this.addListener(SWT.ZoomChanged, this::handleDPIChange);`
	`78`	`+ this._addListener(SWT.ZoomChanged, this::handleDPIChange);`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`/**`