Rename setDirtyIndicatorCloseStyle to setDirtyIndicatorStyle

"CloseStyle" leaks the implementation detail that the bullet occupies
the close button area. The shorter name describes the feature, not
the mechanism.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: vogella

bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CTabFolder.java

@@ -3689,7 +3689,7 @@ public void setUnselectedCloseVisible(boolean visible) {
 	updateFolder(REDRAW);
 }
 /**
- * Sets whether the dirty indicator uses the close button style. When enabled,
+ * Sets whether the dirty indicator style is enabled. When enabled,
  * dirty items (marked via {@link CTabItem#setShowDirty(boolean)}) show a
  * bullet dot at the close button location instead of the traditional
  * <code>*</code> prefix. The bullet transforms into the close button on hover.
@@ -3698,8 +3698,7 @@ public void setUnselectedCloseVisible(boolean visible) {
  * behavior).
  * </p>
  *
- * @param useCloseButtonStyle <code>true</code> to use the bullet-on-close-button
- *        style for dirty indicators
+ * @param enabled <code>true</code> to enable the dirty indicator style
  *
  * @exception SWTException <ul>
  *    <li>ERROR_WIDGET_DISPOSED - if the receiver has been disposed</li>
@@ -3709,26 +3708,26 @@ public void setUnselectedCloseVisible(boolean visible) {
  * @see CTabItem#setShowDirty(boolean)
  * @since 3.134
  */
-public void setDirtyIndicatorCloseStyle(boolean useCloseButtonStyle) {
+public void setDirtyIndicatorStyle(boolean enabled) {
 	checkWidget();
-	if (dirtyIndicatorStyle == useCloseButtonStyle) return;
-	dirtyIndicatorStyle = useCloseButtonStyle;
+	if (dirtyIndicatorStyle == enabled) return;
+	dirtyIndicatorStyle = enabled;
 	updateFolder(REDRAW_TABS);
 }
 /**
- * Returns whether the dirty indicator uses the close button style.
+ * Returns whether the dirty indicator style is enabled.
  *
- * @return <code>true</code> if the dirty indicator uses the close button style
+ * @return <code>true</code> if the dirty indicator style is enabled
  *
  * @exception SWTException <ul>
  *    <li>ERROR_WIDGET_DISPOSED - if the receiver has been disposed</li>
  *    <li>ERROR_THREAD_INVALID_ACCESS - if not called from the thread that created the receiver</li>
  * </ul>
  *
- * @see #setDirtyIndicatorCloseStyle(boolean)
+ * @see #setDirtyIndicatorStyle(boolean)
  * @since 3.134
  */
-public boolean getDirtyIndicatorCloseStyle() {
+public boolean getDirtyIndicatorStyle() {
 	checkWidget();
 	return dirtyIndicatorStyle;
 }

bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CTabItem.java

@@ -290,7 +290,7 @@ public boolean getShowClose() {
  *    <li>ERROR_THREAD_INVALID_ACCESS - if not called from the thread that created the receiver</li>
  * </ul>
  *
- * @see CTabFolder#setDirtyIndicatorCloseStyle(boolean)
+ * @see CTabFolder#setDirtyIndicatorStyle(boolean)
  * @since 3.134
  */
 public boolean getShowDirty() {
@@ -514,7 +514,7 @@ public void setShowClose(boolean close) {
 /**
  * Marks this item as dirty (having unsaved changes). When the parent
  * folder's dirty indicator style is enabled via
- * {@link CTabFolder#setDirtyIndicatorCloseStyle(boolean)}, dirty items
+ * {@link CTabFolder#setDirtyIndicatorStyle(boolean)}, dirty items
  * show a bullet dot at the close button location. The bullet transforms
  * into the close button on hover.
  *
@@ -525,7 +525,7 @@ public void setShowClose(boolean close) {
  *    <li>ERROR_THREAD_INVALID_ACCESS - if not called from the thread that created the receiver</li>
  * </ul>
  *
- * @see CTabFolder#setDirtyIndicatorCloseStyle(boolean)
+ * @see CTabFolder#setDirtyIndicatorStyle(boolean)
  * @since 3.134
  */
 public void setShowDirty(boolean dirty) {

examples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet393.java

@@ -32,7 +32,7 @@ public static void main(String[] args) {
 
 		CTabFolder folder = new CTabFolder(shell, SWT.CLOSE | SWT.BORDER);
 		folder.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, true));
-		folder.setDirtyIndicatorCloseStyle(true);
+		folder.setDirtyIndicatorStyle(true);
 
 		for (int i = 0; i < 4; i++) {
 			CTabItem item = new CTabItem(folder, SWT.NONE);

tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_custom_CTabItem.java

@@ -90,10 +90,10 @@ public void test_setShowDirty() {
 
 @Test
 public void test_dirtyIndicatorCloseStyle() {
-	assertFalse(cTabFolder.getDirtyIndicatorCloseStyle());
-	cTabFolder.setDirtyIndicatorCloseStyle(true);
-	assertTrue(cTabFolder.getDirtyIndicatorCloseStyle());
-	cTabFolder.setDirtyIndicatorCloseStyle(false);
-	assertFalse(cTabFolder.getDirtyIndicatorCloseStyle());
+	assertFalse(cTabFolder.getDirtyIndicatorStyle());
+	cTabFolder.setDirtyIndicatorStyle(true);
+	assertTrue(cTabFolder.getDirtyIndicatorStyle());
+	cTabFolder.setDirtyIndicatorStyle(false);
+	assertFalse(cTabFolder.getDirtyIndicatorStyle());
 }
 }