Automatic refactoring: move Win32DPIUtils.pointToPixel(size,zoom) to DPIUtil#2629
Merged
HeikoKlare merged 1 commit intoOct 15, 2025
Merged
Conversation
arunjose696
changed the title
Contributor
HeikoKlare
reviewed
Oct 15, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Moving this to DPIUtil seems reasonable to me, as pixelToPoint is also part of that class. I just have minor comments for proper refactoring and cleanup.
…DPIUtils The change is required to do pointToPixel conversions in GTK and MACOS which would be required in follow up PRs
arunjose696
force-pushed
the
arunjose696/MovePointToPixel
branch
from
ac8de0d to
6c9839b
Compare
HeikoKlare
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change is required for the below PRs as they would need to do point to pixel conversions