Skip to content

Use timer unconditionally in BusyIndicator.showWhile(Future) #3167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akurtakov wants to merge 1 commit into from
+13 −13
Closed

Use timer unconditionally in BusyIndicator.showWhile(Future) #3167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions ...g.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/BusyIndicator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,19 @@ public static void showWhile(Future<?> future) {
} else {
Integer busyId = setBusyCursor(display);
try {
// Install a timer as a safety net to periodically wake the event loop in case
// the primary wake signal is lost (e.g. due to a native call may fail to wake the polling function).
// That should be short enough to not be noticeable by the user and long
// enough to not burn more CPU time than necessary
int wakeTime = 10;
display.timerExec(wakeTime, new Runnable() {
@Override
public void run() {
if (!future.isDone() && !display.isDisposed()) {
display.timerExec(wakeTime, this);
}
}
});
if (future instanceof CompletionStage<?> stage) {
// let us wake up from sleep once the future is done
stage.handle((nil1, nil2) -> {
Expand All @@ -119,19 +132,6 @@ public static void showWhile(Future<?> future) {
}
return null;
});
} else {
// for plain features we need to use a workaround, we install a timer every
// few ms, that should be short enough to not be noticeable by the user and long
// enough to not burn more CPU time than necessary
int wakeTime = 10;
display.timerExec(wakeTime, new Runnable() {
@Override
public void run() {
if (!future.isDone() && !display.isDisposed()) {
display.timerExec(wakeTime, this);
}
}
});
}
while (!future.isDone() && !display.isDisposed()) {
if (!display.readAndDispatch()) {
Expand Down
Loading